From: Nick Piggin <npiggin@suse.de>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-fsdevel@vger.kernel.org
Subject: Re: [rfc][patch] mm: direct io less aggressive syncs and invalidates
Date: Thu, 30 Oct 2008 03:08:39 +0100 [thread overview]
Message-ID: <20081030020839.GD18041@wotan.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0810290958240.7950@hs20-bc2-1.build.redhat.com>
On Wed, Oct 29, 2008 at 10:02:43AM -0400, Mikulas Patocka wrote:
>
>
> On Tue, 28 Oct 2008, Nick Piggin wrote:
>
> > Improve this by doing range syncs. Also, memory no longer has to be
> > unmapped to catch the dirty bits for syncing, as dirty bits would remain
> > coherent due to dirty mmap accounting.
>
> mmaped memory doesn't have have to by synchronized at all with read/write.
> It has to be only synchonized if msync or munmap is called --- that's what
> Posix says.
>
> So direct i/o implementation that ignores mmap would be correct. Direct
> i/o implementation that is not synchronized w.r.t. nondirect i/o wouldn't.
Right, but our implementation tries not to ignore mmap.
Our mmap is coherent with buffered IO, and buffered IO (kinda) coherent
with direct IO... least surprise says direct IO should be kinda coherent
with mmap ;)
At least now there is basically no extra cost to it.
prev parent reply other threads:[~2008-10-30 2:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 15:54 [rfc][patch] mm: direct io less aggressive syncs and invalidates Nick Piggin
2008-10-28 21:11 ` Jeff Moyer
2008-10-28 23:52 ` Nick Piggin
2008-10-29 13:12 ` Jeff Moyer
2008-10-29 21:47 ` Dave Chinner
2008-10-30 2:11 ` Nick Piggin
2008-10-30 19:14 ` Jeff Moyer
2008-10-29 0:56 ` Jamie Lokier
2008-10-29 13:30 ` Jeff Moyer
2008-10-29 21:48 ` Dave Chinner
2008-10-29 14:02 ` Mikulas Patocka
2008-10-30 2:08 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081030020839.GD18041@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).