From: Andreas Dilger <adilger@sun.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Josef Bacik <jbacik@redhat.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, rwheeler@redhat.com
Subject: Re: [PATCH] improve jbd fsync batching
Date: Mon, 03 Nov 2008 22:24:28 -0700 [thread overview]
Message-ID: <20081104052428.GP3184@webber.adilger.int> (raw)
In-Reply-To: <20081103122729.60582692.akpm@linux-foundation.org>
On Nov 03, 2008 12:27 -0800, Andrew Morton wrote:
> On Tue, 28 Oct 2008 16:16:15 -0400
> Josef Bacik <jbacik@redhat.com> wrote:
> > + spin_lock(&journal->j_state_lock);
> > + commit_time = journal->j_average_commit_time;
> > + spin_unlock(&journal->j_state_lock);
>
> OK, the lock is needed on 32-bit machines, I guess.
Should we pessimize the 64-bit performance in that case, for 32-bit
increasingly rare 32-bit platforms?
It might be useful to have a spin_{,un}lock_64bit_word() helper that
evaluates to a no-op on plaforms that don't need a hammer to do an atomic
64-bit update.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
next prev parent reply other threads:[~2008-11-04 5:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 20:16 [PATCH] improve jbd fsync batching Josef Bacik
2008-10-28 21:38 ` Andreas Dilger
2008-10-28 21:33 ` Josef Bacik
2008-10-28 21:44 ` Arjan van de Ven
2008-10-28 21:56 ` Ric Wheeler
2008-11-03 20:27 ` Andrew Morton
2008-11-03 20:24 ` Josef Bacik
2008-11-03 20:55 ` Andrew Morton
2008-11-04 15:41 ` Josef Bacik
2008-11-03 22:13 ` Theodore Tso
2008-11-04 5:24 ` Andreas Dilger [this message]
2008-11-04 9:12 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081104052428.GP3184@webber.adilger.int \
--to=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=jbacik@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rwheeler@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).