From: Christoph Hellwig <hch@infradead.org>
To: J??rn Engel <joern@logfs.org>
Cc: Warren Turkal <wt@penguintechs.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Roman Zippel <zippel@linux-m68k.org>
Subject: Re: [PATCH] Fix journal detection on HFS+.
Date: Wed, 5 Nov 2008 09:09:37 -0500 [thread overview]
Message-ID: <20081105140937.GA27438@infradead.org> (raw)
In-Reply-To: <20081105104054.GA6561@logfs.org>
On Wed, Nov 05, 2008 at 11:40:54AM +0100, J??rn Engel wrote:
> On Wed, 5 November 2008 00:00:26 -0800, Warren Turkal wrote:
> >
> > + vhdr->journal_info_block != cpu_to_be32(0)) {
>
> 0 doesn't need explicit cpu_to_be32(). You can drop the whole
> != cpu_to_be32(0)
>
> > + (be32_to_cpu(vhdr->journal_info_block) != 0) &&
>
> Same here.
Yeah. In addition adding a little helper that checks both the journal
flag and the non-zeroness of journal_info_block would be useful so that
everyone adding more checks like this in the future get it right.
next prev parent reply other threads:[~2008-11-05 14:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 8:00 hfsplus journal detection Warren Turkal
2008-11-05 8:00 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-05 8:00 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-05 10:40 ` Jörn Engel
2008-11-05 14:09 ` Christoph Hellwig [this message]
2008-11-06 7:44 ` hfsplus journal detection - next try Warren Turkal
2008-11-06 7:44 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-06 7:44 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-07 8:32 ` Jörn Engel
2008-11-07 18:01 ` Warren Turkal
2008-11-08 11:09 ` Jörn Engel
2008-11-09 5:27 ` Warren Turkal
2008-11-09 11:02 ` Jörn Engel
-- strict thread matches above, loose matches on Subject: below --
2008-11-08 8:55 hfsplus journal detection - try 3 Warren Turkal
2008-11-08 8:55 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-08 8:55 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-11 20:56 hfsplus journal detection - try 4 Warren Turkal
2008-11-11 20:56 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-11 20:56 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-19 22:51 ` Andrew Morton
2008-11-20 1:01 ` Warren Turkal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081105140937.GA27438@infradead.org \
--to=hch@infradead.org \
--cc=joern@logfs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=wt@penguintechs.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).