From: Christoph Hellwig <hch@infradead.org>
To: Peter Staubach <staubach@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH]: ext4: fix big endian
Date: Thu, 6 Nov 2008 11:38:46 -0500 [thread overview]
Message-ID: <20081106163846.GA1381@infradead.org> (raw)
In-Reply-To: <49131601.50407@redhat.com>
On Thu, Nov 06, 2008 at 11:06:25AM -0500, Peter Staubach wrote:
>> Index: kvm/fs/ext4/super.c
>> ===================================================================
>> --- kvm.orig/fs/ext4/super.c
>> +++ kvm/fs/ext4/super.c
>> @@ -1455,7 +1455,7 @@ static int ext4_fill_flex_info(struct su
>> /* We allocate both existing and potentially added groups */
>> flex_group_count = ((sbi->s_groups_count + groups_per_flex - 1) +
>> - ((sbi->s_es->s_reserved_gdt_blocks +1 ) <<
>> + (le16_to_cpu(sbi->s_es->s_reserved_gdt_blocks + 1) <<
>>
>
> I suspect that you want to do the le16_to_cpu() and _then_
> add the 1. Otherwise, adding 1 to a different byte order
> value won't do quite what is expected or hoped for...
Yes. And if someone ran sparse over the code both the initial error
and this varaint would be trivial to spot..
next prev parent reply other threads:[~2008-11-06 16:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 15:00 EXT4-fs: not enough memory for 522250 flex groups Christian Borntraeger
2008-11-06 15:51 ` [PATCH]: ext4: fix big endian (was: not enough memory for 522250 flex groups) Christian Borntraeger
2008-11-06 16:06 ` [PATCH]: ext4: fix big endian Peter Staubach
2008-11-06 16:15 ` Christian Borntraeger
2008-11-06 16:32 ` Aneesh Kumar K.V
2008-11-06 16:38 ` Christoph Hellwig [this message]
2008-11-06 17:11 ` Christian Borntraeger
2008-11-06 17:33 ` Theodore Tso
2008-11-06 17:39 ` Christoph Hellwig
[not found] ` <20081106173944.GA23398@infradead.org>
2008-11-06 17:48 ` Alexey Dobriyan
2008-11-08 22:35 ` Jörn Engel
2008-11-10 18:09 ` Harvey Harrison
2008-11-10 19:31 ` Jörn Engel
2008-11-06 16:06 ` [PATCH]: ext4: fix big endian (was: not enough memory for 522250 flex groups) Andreas Schwab
2008-11-06 16:59 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081106163846.GA1381@infradead.org \
--to=hch@infradead.org \
--cc=borntraeger@de.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=staubach@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).