From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?SsO2cm4=?= Engel Subject: Re: [PATCH] Fix journal detection on HFS+. Date: Fri, 7 Nov 2008 09:32:51 +0100 Message-ID: <20081107083250.GA29200@logfs.org> References: <20081105140937.GA27438@infradead.org> <1225957463-29519-1-git-send-email-wt@penguintechs.org> <1225957463-29519-2-git-send-email-wt@penguintechs.org> <1225957463-29519-3-git-send-email-wt@penguintechs.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel , Roman Zippel To: Warren Turkal Return-path: Received: from lazybastard.de ([212.112.238.170]:43910 "EHLO longford.logfs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbYKGIdB (ORCPT ); Fri, 7 Nov 2008 03:33:01 -0500 Content-Disposition: inline In-Reply-To: <1225957463-29519-3-git-send-email-wt@penguintechs.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 5 November 2008 23:44:23 -0800, Warren Turkal wrote: >=20 > -hfsplus-objs :=3D super.o options.o inode.o ioctl.o extents.o catalo= g.o dir.o btree.o \ > - bnode.o brec.o bfind.o tables.o unicode.o wrapper.o bitmap.o part_= tbl.o > +hfsplus-objs :=3D super.o options.o inode.o ioctl.o extents.o catalo= g.o dir.o \ > + btree.o bnode.o brec.o bfind.o tables.o unicode.o wrapper.o \ > + bitmap.o part_tbl.o journal.o Didn't check-read your patch? Remove, please. > diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h > index f027a90..9018d2d 100644 > --- a/fs/hfsplus/hfsplus_fs.h > +++ b/fs/hfsplus/hfsplus_fs.h > @@ -421,4 +421,6 @@ static inline struct hfsplus_inode_info *HFSPLUS_= I(struct inode *inode) > =20 > #define kdev_t_to_nr(x) (x) > =20 > +bool hfsp_vol_has_journal(struct hfsplus_vh *vhdr); > + The function is only ever used in super.c. Just leave it in the same file and make it static. J=C3=B6rn --=20 Premature optimization is the root of all evil. -- Donald Knuth -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html