From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?SsO2cm4=?= Engel Subject: Re: [PATCH] Fix journal detection on HFS+. Date: Sat, 8 Nov 2008 12:09:53 +0100 Message-ID: <20081108110953.GA9216@logfs.org> References: <20081105140937.GA27438@infradead.org> <1225957463-29519-1-git-send-email-wt@penguintechs.org> <1225957463-29519-2-git-send-email-wt@penguintechs.org> <1225957463-29519-3-git-send-email-wt@penguintechs.org> <20081107083250.GA29200@logfs.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel , Roman Zippel To: Warren Turkal Return-path: Received: from lazybastard.de ([212.112.238.170]:56716 "EHLO longford.logfs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752822AbYKHLKE (ORCPT ); Sat, 8 Nov 2008 06:10:04 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, 7 November 2008 10:01:07 -0800, Warren Turkal wrote: >=20 > I am sorry, but I don't understand this comment. What is check-read? > Do you want me to remove the journal.o from the hfsplus-objs line? Honestly, I didn't even notice you created a new file for that one function. This hunk looked like something completely unrelated - reformatting can hide functional changes. /me whistles innocently J=C3=B6rn --=20 Measure. Don't tune for speed until you've measured, and even then don't unless one part of the code overwhelms the rest. -- Rob Pike -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html