From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: UNMAP is a hint Date: Mon, 10 Nov 2008 10:30:03 -0700 Message-ID: <20081110173002.GO15439@parisc-linux.org> References: <4913028B.6010405@redhat.com> <1225984628.4703.80.camel@localhost.localdomain> <20081107120534.GO21867@kernel.dk> <1226072970.15281.46.camel@think.oraclecorp.com> <20081109233639.GT4985@disturbed> <9FA859626025B64FBC2AF149D97C944A8A648D@CORPUSMX80A.corp.emc.com> <20081110083126.GF2373@disturbed> <1226311189.4367.30.camel@macbook.infradead.org> <9FA859626025B64FBC2AF149D97C944A8A64A6@CORPUSMX80A.corp.emc.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dwmw2@infradead.org, david@fromorbit.com, martin.petersen@oracle.com, chris.mason@oracle.com, jens.axboe@oracle.com, James.Bottomley@hansenpartnership.com, rwheeler@redhat.com, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org, coughlan@redhat.com To: Black_David@emc.com Return-path: Received: from palinux.external.hp.com ([192.25.206.14]:45355 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754031AbYKJRaU (ORCPT ); Mon, 10 Nov 2008 12:30:20 -0500 Content-Disposition: inline In-Reply-To: <9FA859626025B64FBC2AF149D97C944A8A64A6@CORPUSMX80A.corp.emc.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Nov 10, 2008 at 12:05:57PM -0500, Black_David@emc.com wrote: > > On Mon, 2008-11-10 at 19:31 +1100, Dave Chinner wrote: > > > I think this is the crux of the issue. IMO, it's not much of a > standard > > > when the spirit of the standard is to allow everyone to implement > > > different, non-deterministic behaviour.... > > > > I disagree. The discard request is a _hint_ from the upper layers, and > > the storage device can act on that hint as it sees fit. There's > nothing > > wrong with that; it doesn't make it "not much of a standard". > > Bingo! That is exactly the spirit and thinking behind the UNMAP > proposal. While that may be, it's hardly the spirit that Ric (at least) has been promoting with dire warnings about how 'Enterprise class' customers will react if Linux does the wrong thing for EMC arrays with discard/trim/unmap. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."