* [PATCH] fs/binfmt_misc.c: let binfmt status be more readable
@ 2008-11-17 7:38 Qinghuang Feng
2008-11-19 0:36 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Qinghuang Feng @ 2008-11-17 7:38 UTC (permalink / raw)
To: linux-kernel; +Cc: Alexander Viro, linux-fsdevel, qhfeng.kernel
The following is what it looks like before patching.
It is not much readable.
user@ubuntu:/proc/sys/fs/binfmt_misc$ cat status
enableduser@ubuntu:/proc/sys/fs/binfmt_misc$
Signed-off-by: Qinghuang Feng <qhfeng.kernel@gmail.com>
---
diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c
index f2744ab..72e8b24 100644
--- a/fs/binfmt_misc.c
+++ b/fs/binfmt_misc.c
@@ -652,7 +652,7 @@ static const struct file_operations bm_register_operations = {
static ssize_t
bm_status_read(struct file *file, char __user *buf, size_t nbytes, loff_t *ppos)
{
- char *s = enabled ? "enabled" : "disabled";
+ char *s = enabled ? "enabled\n" : "disabled\n";
return simple_read_from_buffer(buf, nbytes, ppos, s, strlen(s));
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fs/binfmt_misc.c: let binfmt status be more readable
2008-11-17 7:38 [PATCH] fs/binfmt_misc.c: let binfmt status be more readable Qinghuang Feng
@ 2008-11-19 0:36 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2008-11-19 0:36 UTC (permalink / raw)
To: Qinghuang Feng; +Cc: linux-kernel, viro, linux-fsdevel, qhfeng.kernel
On Mon, 17 Nov 2008 15:38:16 +0800
Qinghuang Feng <qhfeng.kernel@gmail.com> wrote:
> The following is what it looks like before patching.
> It is not much readable.
>
> user@ubuntu:/proc/sys/fs/binfmt_misc$ cat status
> enableduser@ubuntu:/proc/sys/fs/binfmt_misc$
>
> Signed-off-by: Qinghuang Feng <qhfeng.kernel@gmail.com>
> ---
> diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c
> index f2744ab..72e8b24 100644
> --- a/fs/binfmt_misc.c
> +++ b/fs/binfmt_misc.c
> @@ -652,7 +652,7 @@ static const struct file_operations bm_register_operations = {
> static ssize_t
> bm_status_read(struct file *file, char __user *buf, size_t nbytes, loff_t *ppos)
> {
> - char *s = enabled ? "enabled" : "disabled";
> + char *s = enabled ? "enabled\n" : "disabled\n";
>
> return simple_read_from_buffer(buf, nbytes, ppos, s, strlen(s));
> }
Well. That's a bugfix, really.
It fixes a bug which has been there for a very long time, in a way
which is non-backward-compatible.
Are there existing applications out there which will disastrously fail
if we add a newline to the /proc/sys/fs/binfmt_misc/status contents? I
somehow doubt it. But we shall find out :)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-19 0:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-17 7:38 [PATCH] fs/binfmt_misc.c: let binfmt status be more readable Qinghuang Feng
2008-11-19 0:36 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).