* [PATCH] Fix journal detection on HFS+.
2008-11-05 8:00 ` [PATCH] Identify journal info block in volume header Warren Turkal
@ 2008-11-05 8:00 ` Warren Turkal
2008-11-05 10:40 ` Jörn Engel
0 siblings, 1 reply; 25+ messages in thread
From: Warren Turkal @ 2008-11-05 8:00 UTC (permalink / raw)
To: linux-fsdevel; +Cc: Roman Zippel, Warren Turkal
The code was unconditionally assumming that the volume had a jounal if the
jounal attribute was set in the volume header. However, the volume also has to
have a non-zero journal info block to actually have a journal.
Signed-off-by: Warren Turkal <wt@penguintechs.org>
---
fs/hfsplus/super.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c
index eb74531..b12e767 100644
--- a/fs/hfsplus/super.c
+++ b/fs/hfsplus/super.c
@@ -260,7 +260,8 @@ static int hfsplus_remount(struct super_block *sb, int *flags, char *data)
printk(KERN_WARNING "hfs: filesystem is marked locked, leaving read-only.\n");
sb->s_flags |= MS_RDONLY;
*flags |= MS_RDONLY;
- } else if (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED)) {
+ } else if (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED) &&
+ vhdr->journal_info_block != cpu_to_be32(0)) {
printk(KERN_WARNING "hfs: filesystem is marked journaled, leaving read-only.\n");
sb->s_flags |= MS_RDONLY;
*flags |= MS_RDONLY;
@@ -356,7 +357,9 @@ static int hfsplus_fill_super(struct super_block *sb, void *data, int silent)
} else if (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_SOFTLOCK)) {
printk(KERN_WARNING "hfs: Filesystem is marked locked, mounting read-only.\n");
sb->s_flags |= MS_RDONLY;
- } else if ((vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED)) && !(sb->s_flags & MS_RDONLY)) {
+ } else if ((vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED)) &&
+ (be32_to_cpu(vhdr->journal_info_block) != 0) &&
+ !(sb->s_flags & MS_RDONLY)) {
printk(KERN_WARNING "hfs: write access to a journaled filesystem is not supported, "
"use the force option at your own risk, mounting read-only.\n");
sb->s_flags |= MS_RDONLY;
--
1.5.6.3
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH] Fix journal detection on HFS+.
2008-11-05 8:00 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
@ 2008-11-05 10:40 ` Jörn Engel
2008-11-05 14:09 ` Christoph Hellwig
0 siblings, 1 reply; 25+ messages in thread
From: Jörn Engel @ 2008-11-05 10:40 UTC (permalink / raw)
To: Warren Turkal; +Cc: linux-fsdevel, Roman Zippel
On Wed, 5 November 2008 00:00:26 -0800, Warren Turkal wrote:
>
> + vhdr->journal_info_block != cpu_to_be32(0)) {
0 doesn't need explicit cpu_to_be32(). You can drop the whole
!= cpu_to_be32(0)
> + (be32_to_cpu(vhdr->journal_info_block) != 0) &&
Same here.
Jörn
--
This above all: to thine own self be true.
-- Shakespeare
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] Fix journal detection on HFS+.
2008-11-05 10:40 ` Jörn Engel
@ 2008-11-05 14:09 ` Christoph Hellwig
2008-11-06 7:44 ` hfsplus journal detection - next try Warren Turkal
0 siblings, 1 reply; 25+ messages in thread
From: Christoph Hellwig @ 2008-11-05 14:09 UTC (permalink / raw)
To: J??rn Engel; +Cc: Warren Turkal, linux-fsdevel, Roman Zippel
On Wed, Nov 05, 2008 at 11:40:54AM +0100, J??rn Engel wrote:
> On Wed, 5 November 2008 00:00:26 -0800, Warren Turkal wrote:
> >
> > + vhdr->journal_info_block != cpu_to_be32(0)) {
>
> 0 doesn't need explicit cpu_to_be32(). You can drop the whole
> != cpu_to_be32(0)
>
> > + (be32_to_cpu(vhdr->journal_info_block) != 0) &&
>
> Same here.
Yeah. In addition adding a little helper that checks both the journal
flag and the non-zeroness of journal_info_block would be useful so that
everyone adding more checks like this in the future get it right.
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH] Fix journal detection on HFS+.
2008-11-06 7:44 ` [PATCH] Identify journal info block in volume header Warren Turkal
@ 2008-11-06 7:44 ` Warren Turkal
2008-11-07 8:32 ` Jörn Engel
0 siblings, 1 reply; 25+ messages in thread
From: Warren Turkal @ 2008-11-06 7:44 UTC (permalink / raw)
To: linux-fsdevel; +Cc: Roman Zippel, Warren Turkal
The code was unconditionally assumming that the volume had a jounal if the
jounal attribute was set in the volume header. However, the volume also has to
have a non-zero journal info block to actually have a journal.
Signed-off-by: Warren Turkal <wt@penguintechs.org>
---
fs/hfsplus/Makefile | 5 +++--
fs/hfsplus/hfsplus_fs.h | 2 ++
fs/hfsplus/journal.c | 14 ++++++++++++++
fs/hfsplus/super.c | 4 ++--
4 files changed, 21 insertions(+), 4 deletions(-)
create mode 100644 fs/hfsplus/journal.c
diff --git a/fs/hfsplus/Makefile b/fs/hfsplus/Makefile
index 3cc0df7..a90cdcb 100644
--- a/fs/hfsplus/Makefile
+++ b/fs/hfsplus/Makefile
@@ -4,6 +4,7 @@
obj-$(CONFIG_HFSPLUS_FS) += hfsplus.o
-hfsplus-objs := super.o options.o inode.o ioctl.o extents.o catalog.o dir.o btree.o \
- bnode.o brec.o bfind.o tables.o unicode.o wrapper.o bitmap.o part_tbl.o
+hfsplus-objs := super.o options.o inode.o ioctl.o extents.o catalog.o dir.o \
+ btree.o bnode.o brec.o bfind.o tables.o unicode.o wrapper.o \
+ bitmap.o part_tbl.o journal.o
diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h
index f027a90..9018d2d 100644
--- a/fs/hfsplus/hfsplus_fs.h
+++ b/fs/hfsplus/hfsplus_fs.h
@@ -421,4 +421,6 @@ static inline struct hfsplus_inode_info *HFSPLUS_I(struct inode *inode)
#define kdev_t_to_nr(x) (x)
+bool hfsp_vol_has_journal(struct hfsplus_vh *vhdr);
+
#endif
diff --git a/fs/hfsplus/journal.c b/fs/hfsplus/journal.c
new file mode 100644
index 0000000..7a5ef2a
--- /dev/null
+++ b/fs/hfsplus/journal.c
@@ -0,0 +1,14 @@
+/*
+ * linux/fs/hfsplus/journal.c
+ * Copyright (c) 2008 Warren Turkal
+ *
+ * Journal related routines
+ */
+
+#include "hfsplus_fs.h"
+
+bool hfsp_vol_has_journal(struct hfsplus_vh *vhdr)
+{
+ return (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED) &&
+ vhdr->journal_info_block);
+}
diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c
index eb74531..9293c9a 100644
--- a/fs/hfsplus/super.c
+++ b/fs/hfsplus/super.c
@@ -260,7 +260,7 @@ static int hfsplus_remount(struct super_block *sb, int *flags, char *data)
printk(KERN_WARNING "hfs: filesystem is marked locked, leaving read-only.\n");
sb->s_flags |= MS_RDONLY;
*flags |= MS_RDONLY;
- } else if (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED)) {
+ } else if (hfsp_vol_has_journal(vhdr)) {
printk(KERN_WARNING "hfs: filesystem is marked journaled, leaving read-only.\n");
sb->s_flags |= MS_RDONLY;
*flags |= MS_RDONLY;
@@ -356,7 +356,7 @@ static int hfsplus_fill_super(struct super_block *sb, void *data, int silent)
} else if (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_SOFTLOCK)) {
printk(KERN_WARNING "hfs: Filesystem is marked locked, mounting read-only.\n");
sb->s_flags |= MS_RDONLY;
- } else if ((vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED)) && !(sb->s_flags & MS_RDONLY)) {
+ } else if (hfsp_vol_has_journal(vhdr) && !(sb->s_flags & MS_RDONLY)) {
printk(KERN_WARNING "hfs: write access to a journaled filesystem is not supported, "
"use the force option at your own risk, mounting read-only.\n");
sb->s_flags |= MS_RDONLY;
--
1.5.6.3
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH] Fix journal detection on HFS+.
2008-11-06 7:44 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
@ 2008-11-07 8:32 ` Jörn Engel
2008-11-07 18:01 ` Warren Turkal
0 siblings, 1 reply; 25+ messages in thread
From: Jörn Engel @ 2008-11-07 8:32 UTC (permalink / raw)
To: Warren Turkal; +Cc: linux-fsdevel, Roman Zippel
On Wed, 5 November 2008 23:44:23 -0800, Warren Turkal wrote:
>
> -hfsplus-objs := super.o options.o inode.o ioctl.o extents.o catalog.o dir.o btree.o \
> - bnode.o brec.o bfind.o tables.o unicode.o wrapper.o bitmap.o part_tbl.o
> +hfsplus-objs := super.o options.o inode.o ioctl.o extents.o catalog.o dir.o \
> + btree.o bnode.o brec.o bfind.o tables.o unicode.o wrapper.o \
> + bitmap.o part_tbl.o journal.o
Didn't check-read your patch? Remove, please.
> diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h
> index f027a90..9018d2d 100644
> --- a/fs/hfsplus/hfsplus_fs.h
> +++ b/fs/hfsplus/hfsplus_fs.h
> @@ -421,4 +421,6 @@ static inline struct hfsplus_inode_info *HFSPLUS_I(struct inode *inode)
>
> #define kdev_t_to_nr(x) (x)
>
> +bool hfsp_vol_has_journal(struct hfsplus_vh *vhdr);
> +
The function is only ever used in super.c. Just leave it in the same
file and make it static.
Jörn
--
Premature optimization is the root of all evil.
-- Donald Knuth
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] Fix journal detection on HFS+.
2008-11-07 8:32 ` Jörn Engel
@ 2008-11-07 18:01 ` Warren Turkal
2008-11-08 11:09 ` Jörn Engel
0 siblings, 1 reply; 25+ messages in thread
From: Warren Turkal @ 2008-11-07 18:01 UTC (permalink / raw)
To: Jörn Engel; +Cc: linux-fsdevel, Roman Zippel
On Fri, Nov 7, 2008 at 12:32 AM, Jörn Engel <joern@logfs.org> wrote:
> On Wed, 5 November 2008 23:44:23 -0800, Warren Turkal wrote:
>>
>> -hfsplus-objs := super.o options.o inode.o ioctl.o extents.o catalog.o dir.o btree.o \
>> - bnode.o brec.o bfind.o tables.o unicode.o wrapper.o bitmap.o part_tbl.o
>> +hfsplus-objs := super.o options.o inode.o ioctl.o extents.o catalog.o dir.o \
>> + btree.o bnode.o brec.o bfind.o tables.o unicode.o wrapper.o \
>> + bitmap.o part_tbl.o journal.o
>
> Didn't check-read your patch? Remove, please.
I am sorry, but I don't understand this comment. What is check-read?
Do you want me to remove the journal.o from the hfsplus-objs line?
>> diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h
>> index f027a90..9018d2d 100644
>> --- a/fs/hfsplus/hfsplus_fs.h
>> +++ b/fs/hfsplus/hfsplus_fs.h
>> @@ -421,4 +421,6 @@ static inline struct hfsplus_inode_info *HFSPLUS_I(struct inode *inode)
>>
>> #define kdev_t_to_nr(x) (x)
>>
>> +bool hfsp_vol_has_journal(struct hfsplus_vh *vhdr);
>> +
>
> The function is only ever used in super.c. Just leave it in the same
> file and make it static.
Okay...will do.
wt
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH] Fix journal detection on HFS+.
2008-11-08 8:55 ` [PATCH] Identify journal info block in volume header Warren Turkal
@ 2008-11-08 8:55 ` Warren Turkal
0 siblings, 0 replies; 25+ messages in thread
From: Warren Turkal @ 2008-11-08 8:55 UTC (permalink / raw)
To: linux-fsdevel; +Cc: Roman Zippel, Warren Turkal
The code was unconditionally assumming that the volume had a jounal if the
jounal attribute was set in the volume header. However, the volume also has to
have a non-zero journal info block to actually have a journal.
Signed-off-by: Warren Turkal <wt@penguintechs.org>
---
fs/hfsplus/super.c | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c
index eb74531..128101b 100644
--- a/fs/hfsplus/super.c
+++ b/fs/hfsplus/super.c
@@ -17,9 +17,16 @@
static struct inode *hfsplus_alloc_inode(struct super_block *sb);
static void hfsplus_destroy_inode(struct inode *inode);
+static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr);
#include "hfsplus_fs.h"
+static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr)
+{
+ return (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED) &&
+ vhdr->journal_info_block);
+}
+
struct inode *hfsplus_iget(struct super_block *sb, unsigned long ino)
{
struct hfs_find_data fd;
@@ -260,7 +267,7 @@ static int hfsplus_remount(struct super_block *sb, int *flags, char *data)
printk(KERN_WARNING "hfs: filesystem is marked locked, leaving read-only.\n");
sb->s_flags |= MS_RDONLY;
*flags |= MS_RDONLY;
- } else if (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED)) {
+ } else if (hfsplus_vol_has_journal(vhdr)) {
printk(KERN_WARNING "hfs: filesystem is marked journaled, leaving read-only.\n");
sb->s_flags |= MS_RDONLY;
*flags |= MS_RDONLY;
@@ -356,7 +363,7 @@ static int hfsplus_fill_super(struct super_block *sb, void *data, int silent)
} else if (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_SOFTLOCK)) {
printk(KERN_WARNING "hfs: Filesystem is marked locked, mounting read-only.\n");
sb->s_flags |= MS_RDONLY;
- } else if ((vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED)) && !(sb->s_flags & MS_RDONLY)) {
+ } else if (hfsplus_vol_has_journal(vhdr) && !(sb->s_flags & MS_RDONLY)) {
printk(KERN_WARNING "hfs: write access to a journaled filesystem is not supported, "
"use the force option at your own risk, mounting read-only.\n");
sb->s_flags |= MS_RDONLY;
--
1.5.6.3
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH] Fix journal detection on HFS+.
2008-11-07 18:01 ` Warren Turkal
@ 2008-11-08 11:09 ` Jörn Engel
2008-11-09 5:27 ` Warren Turkal
0 siblings, 1 reply; 25+ messages in thread
From: Jörn Engel @ 2008-11-08 11:09 UTC (permalink / raw)
To: Warren Turkal; +Cc: linux-fsdevel, Roman Zippel
On Fri, 7 November 2008 10:01:07 -0800, Warren Turkal wrote:
>
> I am sorry, but I don't understand this comment. What is check-read?
> Do you want me to remove the journal.o from the hfsplus-objs line?
Honestly, I didn't even notice you created a new file for that one
function. This hunk looked like something completely unrelated -
reformatting can hide functional changes.
/me whistles innocently
Jörn
--
Measure. Don't tune for speed until you've measured, and even then
don't unless one part of the code overwhelms the rest.
-- Rob Pike
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] Fix journal detection on HFS+.
2008-11-08 11:09 ` Jörn Engel
@ 2008-11-09 5:27 ` Warren Turkal
2008-11-09 11:02 ` Jörn Engel
0 siblings, 1 reply; 25+ messages in thread
From: Warren Turkal @ 2008-11-09 5:27 UTC (permalink / raw)
To: Jörn Engel; +Cc: linux-fsdevel, Roman Zippel
Is everything looking ok at this point?
wt
On Sat, Nov 8, 2008 at 3:09 AM, Jörn Engel <joern@logfs.org> wrote:
> On Fri, 7 November 2008 10:01:07 -0800, Warren Turkal wrote:
>>
>> I am sorry, but I don't understand this comment. What is check-read?
>> Do you want me to remove the journal.o from the hfsplus-objs line?
>
> Honestly, I didn't even notice you created a new file for that one
> function. This hunk looked like something completely unrelated -
> reformatting can hide functional changes.
>
> /me whistles innocently
>
> Jörn
>
> --
> Measure. Don't tune for speed until you've measured, and even then
> don't unless one part of the code overwhelms the rest.
> -- Rob Pike
>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] Fix journal detection on HFS+.
2008-11-09 5:27 ` Warren Turkal
@ 2008-11-09 11:02 ` Jörn Engel
0 siblings, 0 replies; 25+ messages in thread
From: Jörn Engel @ 2008-11-09 11:02 UTC (permalink / raw)
To: Warren Turkal; +Cc: linux-fsdevel, Roman Zippel
On Sat, 8 November 2008 21:27:30 -0800, Warren Turkal wrote:
>
> Is everything looking ok at this point?
Yes.
Jörn
--
And spam is a useful source of entropy for /dev/random too!
-- Jasmine Strong
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 25+ messages in thread
* hfsplus journal detection - try 4
@ 2008-11-11 20:56 Warren Turkal
2008-11-11 20:56 ` [PATCH] Identify journal info block in volume header Warren Turkal
` (3 more replies)
0 siblings, 4 replies; 25+ messages in thread
From: Warren Turkal @ 2008-11-11 20:56 UTC (permalink / raw)
To: linux-fsdevel; +Cc: Roman Zippel, Warren Turkal
Here's another shot at this patch. I found a small issue with sparse.
If this is suitable for inclusion, could someone please pull it into
their tree so that it can be merged upstream?
Thanks,
wt
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH] Identify journal info block in volume header.
2008-11-11 20:56 hfsplus journal detection - try 4 Warren Turkal
@ 2008-11-11 20:56 ` Warren Turkal
2008-11-11 20:56 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-19 22:49 ` [PATCH] Identify journal info block in volume header Andrew Morton
2008-11-19 7:07 ` hfsplus journal detection - try 4 Warren Turkal
` (2 subsequent siblings)
3 siblings, 2 replies; 25+ messages in thread
From: Warren Turkal @ 2008-11-11 20:56 UTC (permalink / raw)
To: linux-fsdevel; +Cc: Roman Zippel, Warren Turkal
Signed-off-by: Warren Turkal <wt@penguintechs.org>
---
fs/hfsplus/hfsplus_raw.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/hfsplus/hfsplus_raw.h b/fs/hfsplus/hfsplus_raw.h
index fe99fe8..14f1dd8 100644
--- a/fs/hfsplus/hfsplus_raw.h
+++ b/fs/hfsplus/hfsplus_raw.h
@@ -94,7 +94,7 @@ struct hfsplus_vh {
__be16 version;
__be32 attributes;
__be32 last_mount_vers;
- u32 reserved;
+ __be32 journal_info_block;
__be32 create_date;
__be32 modify_date;
--
1.5.6.3
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH] Fix journal detection on HFS+.
2008-11-11 20:56 ` [PATCH] Identify journal info block in volume header Warren Turkal
@ 2008-11-11 20:56 ` Warren Turkal
2008-11-11 20:56 ` [PATCH] Fix header include Warren Turkal
2008-11-19 22:51 ` [PATCH] Fix journal detection on HFS+ Andrew Morton
2008-11-19 22:49 ` [PATCH] Identify journal info block in volume header Andrew Morton
1 sibling, 2 replies; 25+ messages in thread
From: Warren Turkal @ 2008-11-11 20:56 UTC (permalink / raw)
To: linux-fsdevel; +Cc: Roman Zippel, Warren Turkal
The code was unconditionally assumming that the volume had a jounal if the
jounal attribute was set in the volume header. However, the volume also has to
have a non-zero journal info block to actually have a journal.
Signed-off-by: Warren Turkal <wt@penguintechs.org>
---
fs/hfsplus/super.c | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c
index eb74531..128101b 100644
--- a/fs/hfsplus/super.c
+++ b/fs/hfsplus/super.c
@@ -17,9 +17,16 @@
static struct inode *hfsplus_alloc_inode(struct super_block *sb);
static void hfsplus_destroy_inode(struct inode *inode);
+static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr);
#include "hfsplus_fs.h"
+static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr)
+{
+ return (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED) &&
+ vhdr->journal_info_block);
+}
+
struct inode *hfsplus_iget(struct super_block *sb, unsigned long ino)
{
struct hfs_find_data fd;
@@ -260,7 +267,7 @@ static int hfsplus_remount(struct super_block *sb, int *flags, char *data)
printk(KERN_WARNING "hfs: filesystem is marked locked, leaving read-only.\n");
sb->s_flags |= MS_RDONLY;
*flags |= MS_RDONLY;
- } else if (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED)) {
+ } else if (hfsplus_vol_has_journal(vhdr)) {
printk(KERN_WARNING "hfs: filesystem is marked journaled, leaving read-only.\n");
sb->s_flags |= MS_RDONLY;
*flags |= MS_RDONLY;
@@ -356,7 +363,7 @@ static int hfsplus_fill_super(struct super_block *sb, void *data, int silent)
} else if (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_SOFTLOCK)) {
printk(KERN_WARNING "hfs: Filesystem is marked locked, mounting read-only.\n");
sb->s_flags |= MS_RDONLY;
- } else if ((vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED)) && !(sb->s_flags & MS_RDONLY)) {
+ } else if (hfsplus_vol_has_journal(vhdr) && !(sb->s_flags & MS_RDONLY)) {
printk(KERN_WARNING "hfs: write access to a journaled filesystem is not supported, "
"use the force option at your own risk, mounting read-only.\n");
sb->s_flags |= MS_RDONLY;
--
1.5.6.3
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH] Fix header include.
2008-11-11 20:56 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
@ 2008-11-11 20:56 ` Warren Turkal
2008-11-19 22:51 ` Andrew Morton
2008-11-19 22:51 ` [PATCH] Fix journal detection on HFS+ Andrew Morton
1 sibling, 1 reply; 25+ messages in thread
From: Warren Turkal @ 2008-11-11 20:56 UTC (permalink / raw)
To: linux-fsdevel; +Cc: Roman Zippel, Warren Turkal
Signed-off-by: Warren Turkal <wt@penguintechs.org>
---
fs/hfsplus/super.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c
index 128101b..4f00a84 100644
--- a/fs/hfsplus/super.c
+++ b/fs/hfsplus/super.c
@@ -15,12 +15,12 @@
#include <linux/vfs.h>
#include <linux/nls.h>
+#include "hfsplus_fs.h"
+
static struct inode *hfsplus_alloc_inode(struct super_block *sb);
static void hfsplus_destroy_inode(struct inode *inode);
static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr);
-#include "hfsplus_fs.h"
-
static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr)
{
return (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED) &&
--
1.5.6.3
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: hfsplus journal detection - try 4
2008-11-11 20:56 hfsplus journal detection - try 4 Warren Turkal
2008-11-11 20:56 ` [PATCH] Identify journal info block in volume header Warren Turkal
@ 2008-11-19 7:07 ` Warren Turkal
2008-11-19 8:39 ` Jörn Engel
2008-11-19 22:36 ` Warren Turkal
2008-11-19 22:49 ` Andrew Morton
3 siblings, 1 reply; 25+ messages in thread
From: Warren Turkal @ 2008-11-19 7:07 UTC (permalink / raw)
To: linux-fsdevel; +Cc: Roman Zippel, Warren Turkal
Did anyone pick up this patch set?
wt
On Tue, Nov 11, 2008 at 12:56 PM, Warren Turkal <wt@penguintechs.org> wrote:
> Here's another shot at this patch. I found a small issue with sparse.
> If this is suitable for inclusion, could someone please pull it into
> their tree so that it can be merged upstream?
>
> Thanks,
> wt
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: hfsplus journal detection - try 4
2008-11-19 7:07 ` hfsplus journal detection - try 4 Warren Turkal
@ 2008-11-19 8:39 ` Jörn Engel
0 siblings, 0 replies; 25+ messages in thread
From: Jörn Engel @ 2008-11-19 8:39 UTC (permalink / raw)
To: Warren Turkal; +Cc: linux-fsdevel, Roman Zippel
On Tue, 18 November 2008 23:07:31 -0800, Warren Turkal wrote:
>
> Did anyone pick up this patch set?
You could try sending it to someone who cares. Roman apparently
doesn't, hfsplus is officially unmaintained. Guess that leaves Andrew
Morton.
Jörn
--
There's nothing better for promoting creativity in a medium than
making an audience feel "Hmm I could do better than that!"
-- Douglas Adams in a slashdot interview
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: hfsplus journal detection - try 4
2008-11-11 20:56 hfsplus journal detection - try 4 Warren Turkal
2008-11-11 20:56 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-19 7:07 ` hfsplus journal detection - try 4 Warren Turkal
@ 2008-11-19 22:36 ` Warren Turkal
2008-11-19 22:49 ` Andrew Morton
3 siblings, 0 replies; 25+ messages in thread
From: Warren Turkal @ 2008-11-19 22:36 UTC (permalink / raw)
To: linux-fsdevel, Andrew Morton; +Cc: Roman Zippel, Warren Turkal
Andrew,
I am sending this to you since it's a small patchset and I'm not
getting any traction with the alleged HFS+ maintainer. Is this small
enough to make it into 2.6.28 or will it have to wait for the next
cycle?
BTW, I am the guy who just came to your cube to bug you.
Thanks,
wt
On Tue, Nov 11, 2008 at 12:56 PM, Warren Turkal <wt@penguintechs.org> wrote:
> Here's another shot at this patch. I found a small issue with sparse.
> If this is suitable for inclusion, could someone please pull it into
> their tree so that it can be merged upstream?
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: hfsplus journal detection - try 4
2008-11-11 20:56 hfsplus journal detection - try 4 Warren Turkal
` (2 preceding siblings ...)
2008-11-19 22:36 ` Warren Turkal
@ 2008-11-19 22:49 ` Andrew Morton
3 siblings, 0 replies; 25+ messages in thread
From: Andrew Morton @ 2008-11-19 22:49 UTC (permalink / raw)
To: Warren Turkal; +Cc: linux-fsdevel, zippel, wt
On Tue, 11 Nov 2008 12:56:45 -0800
Warren Turkal <wt@penguintechs.org> wrote:
> Here's another shot at this patch. I found a small issue with sparse.
> If this is suitable for inclusion, could someone please pull it into
> their tree so that it can be merged upstream?
I don't follow linux-fsdevel much. cc'ing linux-kernel gets my attention.
This patchset is missing an overall description of the problem which is
being solved. I can kinda see what the changes do, but it would be
much better if we were provided with a description of the kernel
behaviour before and after the patches.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] Identify journal info block in volume header.
2008-11-11 20:56 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-11 20:56 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
@ 2008-11-19 22:49 ` Andrew Morton
1 sibling, 0 replies; 25+ messages in thread
From: Andrew Morton @ 2008-11-19 22:49 UTC (permalink / raw)
To: Warren Turkal; +Cc: linux-fsdevel, zippel, wt
On Tue, 11 Nov 2008 12:56:46 -0800
Warren Turkal <wt@penguintechs.org> wrote:
> Signed-off-by: Warren Turkal <wt@penguintechs.org>
> ---
> fs/hfsplus/hfsplus_raw.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/hfsplus/hfsplus_raw.h b/fs/hfsplus/hfsplus_raw.h
> index fe99fe8..14f1dd8 100644
> --- a/fs/hfsplus/hfsplus_raw.h
> +++ b/fs/hfsplus/hfsplus_raw.h
> @@ -94,7 +94,7 @@ struct hfsplus_vh {
> __be16 version;
> __be32 attributes;
> __be32 last_mount_vers;
> - u32 reserved;
> + __be32 journal_info_block;
>
> __be32 create_date;
> __be32 modify_date;
Please include a changelog which fully describes the reason for making
this change.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] Fix journal detection on HFS+.
2008-11-11 20:56 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-11 20:56 ` [PATCH] Fix header include Warren Turkal
@ 2008-11-19 22:51 ` Andrew Morton
2008-11-20 1:01 ` Warren Turkal
1 sibling, 1 reply; 25+ messages in thread
From: Andrew Morton @ 2008-11-19 22:51 UTC (permalink / raw)
To: Warren Turkal; +Cc: linux-fsdevel, zippel, wt
On Tue, 11 Nov 2008 12:56:47 -0800
Warren Turkal <wt@penguintechs.org> wrote:
> The code was unconditionally assumming that the volume had a jounal if the
> jounal attribute was set in the volume header. However, the volume also has to
> have a non-zero journal info block to actually have a journal.
OK, but so what?
Presumably there is some situation in which this is causing you a
problem, but what is that situation, and what was the kernel's
behaviour in that situation?
> Signed-off-by: Warren Turkal <wt@penguintechs.org>
> ---
> fs/hfsplus/super.c | 11 +++++++++--
> 1 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c
> index eb74531..128101b 100644
> --- a/fs/hfsplus/super.c
> +++ b/fs/hfsplus/super.c
> @@ -17,9 +17,16 @@
>
> static struct inode *hfsplus_alloc_inode(struct super_block *sb);
> static void hfsplus_destroy_inode(struct inode *inode);
> +static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr);
>
> #include "hfsplus_fs.h"
>
> +static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr)
> +{
> + return (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED) &&
> + vhdr->journal_info_block);
> +}
> +
> struct inode *hfsplus_iget(struct super_block *sb, unsigned long ino)
> {
> struct hfs_find_data fd;
> @@ -260,7 +267,7 @@ static int hfsplus_remount(struct super_block *sb, int *flags, char *data)
> printk(KERN_WARNING "hfs: filesystem is marked locked, leaving read-only.\n");
> sb->s_flags |= MS_RDONLY;
> *flags |= MS_RDONLY;
> - } else if (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED)) {
> + } else if (hfsplus_vol_has_journal(vhdr)) {
> printk(KERN_WARNING "hfs: filesystem is marked journaled, leaving read-only.\n");
> sb->s_flags |= MS_RDONLY;
> *flags |= MS_RDONLY;
> @@ -356,7 +363,7 @@ static int hfsplus_fill_super(struct super_block *sb, void *data, int silent)
> } else if (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_SOFTLOCK)) {
> printk(KERN_WARNING "hfs: Filesystem is marked locked, mounting read-only.\n");
> sb->s_flags |= MS_RDONLY;
> - } else if ((vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED)) && !(sb->s_flags & MS_RDONLY)) {
> + } else if (hfsplus_vol_has_journal(vhdr) && !(sb->s_flags & MS_RDONLY)) {
> printk(KERN_WARNING "hfs: write access to a journaled filesystem is not supported, "
> "use the force option at your own risk, mounting read-only.\n");
> sb->s_flags |= MS_RDONLY;
The patch itself looks OK to me.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] Fix header include.
2008-11-11 20:56 ` [PATCH] Fix header include Warren Turkal
@ 2008-11-19 22:51 ` Andrew Morton
2008-11-19 23:01 ` Brad Boyer
2008-11-20 0:41 ` Brad Boyer
0 siblings, 2 replies; 25+ messages in thread
From: Andrew Morton @ 2008-11-19 22:51 UTC (permalink / raw)
To: Warren Turkal; +Cc: linux-fsdevel, zippel, wt
On Tue, 11 Nov 2008 12:56:48 -0800
Warren Turkal <wt@penguintechs.org> wrote:
> Signed-off-by: Warren Turkal <wt@penguintechs.org>
> ---
> fs/hfsplus/super.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c
> index 128101b..4f00a84 100644
> --- a/fs/hfsplus/super.c
> +++ b/fs/hfsplus/super.c
> @@ -15,12 +15,12 @@
> #include <linux/vfs.h>
> #include <linux/nls.h>
>
> +#include "hfsplus_fs.h"
> +
> static struct inode *hfsplus_alloc_inode(struct super_block *sb);
> static void hfsplus_destroy_inode(struct inode *inode);
> static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr);
>
> -#include "hfsplus_fs.h"
> -
> static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr)
> {
> return (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED) &&
again: what was wrong with the old code??
If it was causing some compilation problem then please quote the compiler
output in the changelog.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] Fix header include.
2008-11-19 22:51 ` Andrew Morton
@ 2008-11-19 23:01 ` Brad Boyer
2008-11-20 0:41 ` Brad Boyer
1 sibling, 0 replies; 25+ messages in thread
From: Brad Boyer @ 2008-11-19 23:01 UTC (permalink / raw)
To: Andrew Morton; +Cc: Warren Turkal, linux-fsdevel, zippel
On Wed, Nov 19, 2008 at 02:51:40PM -0800, Andrew Morton wrote:
> again: what was wrong with the old code??
>
> If it was causing some compilation problem then please quote the compiler
> output in the changelog.
I didn't write this patch, but I was the original author of this driver.
The issue here is that Apple added a journal feature after the fact and
the current Linux driver doesn't support that. The current code just
checks for the equivalent of a feature bit, while this change makes it
also confirm that there really is a journal file. Without this change,
an HFS+ file system that has been setup to do transactional changes but
doesn't currently have an actual journal file allocated will not be
mountable with the Linux driver.
Just as a side note, although I am the original author I have never
claimed to maintain this code. In fact, I wasn't the one that submitted
it for inclusion. In any case, I don't plan on adding myself as maintainer.
Brad Boyer
flar@allandria.com
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] Fix header include.
2008-11-19 22:51 ` Andrew Morton
2008-11-19 23:01 ` Brad Boyer
@ 2008-11-20 0:41 ` Brad Boyer
2008-11-20 2:30 ` Warren Turkal
1 sibling, 1 reply; 25+ messages in thread
From: Brad Boyer @ 2008-11-20 0:41 UTC (permalink / raw)
To: Andrew Morton; +Cc: Warren Turkal, linux-fsdevel, zippel
On Wed, Nov 19, 2008 at 02:51:40PM -0800, Andrew Morton wrote:
> On Tue, 11 Nov 2008 12:56:48 -0800
> Warren Turkal <wt@penguintechs.org> wrote:
> > @@ -15,12 +15,12 @@
> > #include <linux/vfs.h>
> > #include <linux/nls.h>
> >
> > +#include "hfsplus_fs.h"
> > +
> > static struct inode *hfsplus_alloc_inode(struct super_block *sb);
> > static void hfsplus_destroy_inode(struct inode *inode);
> > static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr);
> >
> > -#include "hfsplus_fs.h"
> > -
> > static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr)
> > {
> > return (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED) &&
>
> again: what was wrong with the old code??
I just realized what you were asking after I sent my other reply. The
include needs to move so 'struct hfsplus_vh' is declared before the
function prototype. That happens in hfsplus_fs.h.
My apologies for the noise, although I stand by my statement that I
have no intention of actively maintaining this code myself.
> If it was causing some compilation problem then please quote the compiler
> output in the changelog.
The original submitter would need to include the actual compiler output.
Brad Boyer
flar@allandria.com
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] Fix journal detection on HFS+.
2008-11-19 22:51 ` [PATCH] Fix journal detection on HFS+ Andrew Morton
@ 2008-11-20 1:01 ` Warren Turkal
0 siblings, 0 replies; 25+ messages in thread
From: Warren Turkal @ 2008-11-20 1:01 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-fsdevel, zippel
The kernel was mounting an HFS+ FS ro if the volume header indicated
that it had a journal and the journal info block was 0. The kernel
should just treat the volume as not having a journal in that case.
wt
On Wed, Nov 19, 2008 at 2:51 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Tue, 11 Nov 2008 12:56:47 -0800
> Warren Turkal <wt@penguintechs.org> wrote:
>
>> The code was unconditionally assumming that the volume had a jounal if the
>> jounal attribute was set in the volume header. However, the volume also has to
>> have a non-zero journal info block to actually have a journal.
>
> OK, but so what?
>
> Presumably there is some situation in which this is causing you a
> problem, but what is that situation, and what was the kernel's
> behaviour in that situation?
>
>> Signed-off-by: Warren Turkal <wt@penguintechs.org>
>> ---
>> fs/hfsplus/super.c | 11 +++++++++--
>> 1 files changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c
>> index eb74531..128101b 100644
>> --- a/fs/hfsplus/super.c
>> +++ b/fs/hfsplus/super.c
>> @@ -17,9 +17,16 @@
>>
>> static struct inode *hfsplus_alloc_inode(struct super_block *sb);
>> static void hfsplus_destroy_inode(struct inode *inode);
>> +static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr);
>>
>> #include "hfsplus_fs.h"
>>
>> +static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr)
>> +{
>> + return (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED) &&
>> + vhdr->journal_info_block);
>> +}
>> +
>> struct inode *hfsplus_iget(struct super_block *sb, unsigned long ino)
>> {
>> struct hfs_find_data fd;
>> @@ -260,7 +267,7 @@ static int hfsplus_remount(struct super_block *sb, int *flags, char *data)
>> printk(KERN_WARNING "hfs: filesystem is marked locked, leaving read-only.\n");
>> sb->s_flags |= MS_RDONLY;
>> *flags |= MS_RDONLY;
>> - } else if (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED)) {
>> + } else if (hfsplus_vol_has_journal(vhdr)) {
>> printk(KERN_WARNING "hfs: filesystem is marked journaled, leaving read-only.\n");
>> sb->s_flags |= MS_RDONLY;
>> *flags |= MS_RDONLY;
>> @@ -356,7 +363,7 @@ static int hfsplus_fill_super(struct super_block *sb, void *data, int silent)
>> } else if (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_SOFTLOCK)) {
>> printk(KERN_WARNING "hfs: Filesystem is marked locked, mounting read-only.\n");
>> sb->s_flags |= MS_RDONLY;
>> - } else if ((vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED)) && !(sb->s_flags & MS_RDONLY)) {
>> + } else if (hfsplus_vol_has_journal(vhdr) && !(sb->s_flags & MS_RDONLY)) {
>> printk(KERN_WARNING "hfs: write access to a journaled filesystem is not supported, "
>> "use the force option at your own risk, mounting read-only.\n");
>> sb->s_flags |= MS_RDONLY;
>
> The patch itself looks OK to me.
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] Fix header include.
2008-11-20 0:41 ` Brad Boyer
@ 2008-11-20 2:30 ` Warren Turkal
0 siblings, 0 replies; 25+ messages in thread
From: Warren Turkal @ 2008-11-20 2:30 UTC (permalink / raw)
To: Brad Boyer; +Cc: Andrew Morton, linux-fsdevel, zippel
I just submitted a patchset with more detailed commit comments.. It's
the same change wrapped in a, hopefully, prettier candy coating.
wt
On Wed, Nov 19, 2008 at 4:41 PM, Brad Boyer <flar@allandria.com> wrote:
> On Wed, Nov 19, 2008 at 02:51:40PM -0800, Andrew Morton wrote:
>> On Tue, 11 Nov 2008 12:56:48 -0800
>> Warren Turkal <wt@penguintechs.org> wrote:
>> > @@ -15,12 +15,12 @@
>> > #include <linux/vfs.h>
>> > #include <linux/nls.h>
>> >
>> > +#include "hfsplus_fs.h"
>> > +
>> > static struct inode *hfsplus_alloc_inode(struct super_block *sb);
>> > static void hfsplus_destroy_inode(struct inode *inode);
>> > static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr);
>> >
>> > -#include "hfsplus_fs.h"
>> > -
>> > static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr)
>> > {
>> > return (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED) &&
>>
>> again: what was wrong with the old code??
>
> I just realized what you were asking after I sent my other reply. The
> include needs to move so 'struct hfsplus_vh' is declared before the
> function prototype. That happens in hfsplus_fs.h.
>
> My apologies for the noise, although I stand by my statement that I
> have no intention of actively maintaining this code myself.
>
>> If it was causing some compilation problem then please quote the compiler
>> output in the changelog.
>
> The original submitter would need to include the actual compiler output.
>
> Brad Boyer
> flar@allandria.com
>
>
^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2008-11-20 2:30 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-11 20:56 hfsplus journal detection - try 4 Warren Turkal
2008-11-11 20:56 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-11 20:56 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-11 20:56 ` [PATCH] Fix header include Warren Turkal
2008-11-19 22:51 ` Andrew Morton
2008-11-19 23:01 ` Brad Boyer
2008-11-20 0:41 ` Brad Boyer
2008-11-20 2:30 ` Warren Turkal
2008-11-19 22:51 ` [PATCH] Fix journal detection on HFS+ Andrew Morton
2008-11-20 1:01 ` Warren Turkal
2008-11-19 22:49 ` [PATCH] Identify journal info block in volume header Andrew Morton
2008-11-19 7:07 ` hfsplus journal detection - try 4 Warren Turkal
2008-11-19 8:39 ` Jörn Engel
2008-11-19 22:36 ` Warren Turkal
2008-11-19 22:49 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2008-11-08 8:55 hfsplus journal detection - try 3 Warren Turkal
2008-11-08 8:55 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-08 8:55 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-05 8:00 hfsplus journal detection Warren Turkal
2008-11-05 8:00 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-05 8:00 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-05 10:40 ` Jörn Engel
2008-11-05 14:09 ` Christoph Hellwig
2008-11-06 7:44 ` hfsplus journal detection - next try Warren Turkal
2008-11-06 7:44 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-06 7:44 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-07 8:32 ` Jörn Engel
2008-11-07 18:01 ` Warren Turkal
2008-11-08 11:09 ` Jörn Engel
2008-11-09 5:27 ` Warren Turkal
2008-11-09 11:02 ` Jörn Engel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).