From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?SsO2cm4=?= Engel Subject: Re: [PATCH 2/2] Fix journal detection on HFS+. Date: Thu, 20 Nov 2008 12:29:04 +0100 Message-ID: <20081120112903.GB30887@logfs.org> References: <1227147960-32355-1-git-send-email-wt@penguintechs.org> <1227147960-32355-2-git-send-email-wt@penguintechs.org> <1227147960-32355-3-git-send-email-wt@penguintechs.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Morton , linux-fsdevel@vger.kernel.org To: Warren Turkal Return-path: Received: from lazybastard.de ([212.112.238.170]:38410 "EHLO longford.logfs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755078AbYKTL3P (ORCPT ); Thu, 20 Nov 2008 06:29:15 -0500 Content-Disposition: inline In-Reply-To: <1227147960-32355-3-git-send-email-wt@penguintechs.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 19 November 2008 18:26:00 -0800, Warren Turkal wrote: >=20 > diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c > index eb74531..4f00a84 100644 > --- a/fs/hfsplus/super.c > +++ b/fs/hfsplus/super.c > @@ -15,10 +15,17 @@ > #include > #include > =20 > +#include "hfsplus_fs.h" > + > static struct inode *hfsplus_alloc_inode(struct super_block *sb); > static void hfsplus_destroy_inode(struct inode *inode); > +static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr); Sorry for not noticing this before. The function declaration is unnecessary. There are no callers before the actual function definition, which is just below. > -#include "hfsplus_fs.h" > +static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr) > +{ > + return (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED) && > + vhdr->journal_info_block); > +} You're going through a huge number of iterations for such a simple change. Others would have lost patience some time ago. :( Reviewed-By: Joern Engel J=C3=B6rn --=20 Courage is not the absence of fear, but rather the judgement that something else is more important than fear. -- Ambrose Redmoon -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html