Re: Fwd: fsx-linux failing with latest cifs-2.6 git tree

[Nick Piggin <npiggin@suse.de>]

On Fri, Nov 21, 2008 at 02:41:41PM -0600, Dave Kleikamp wrote:
> On Fri, 2008-11-21 at 14:38 -0600, Steve French wrote:
> > Fix attached.
> > 
> > Shaggy/Jeff/Nick etc. do you want to review/ack it since it is late in the rc?
> 
> Acked-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
> 
> > 
> > On Fri, Nov 21, 2008 at 2:18 PM, Steve French <smfrench@gmail.com> wrote:
> > > Looks like the following change to cifs_write_begin does fix it ...
> > > thanks Shaggy ...
> > >
> > > @@ -2062,8 +2074,10 @@ static int cifs_write_begin(struct file *file,
> > > struct address_space *mapping,
> > >  {
> > >        pgoff_t index = pos >> PAGE_CACHE_SHIFT;
> > >        loff_t offset = pos & (PAGE_CACHE_SIZE - 1);
> > > +       loff_t page_start = pos & PAGE_MASK;
> > >
> > >       cFYI(1, ("write_begin from %lld len %d", (long long)pos, len));
> > > @@ -2081,13 +2095,14 @@ static int cifs_write_begin(struct file *file,
> > > struct address_space *mapping,
> > >                int rc;
> > >
> > >                /* might as well read a page, it is fast enough */
> > > -               rc = cifs_readpage_worker(file, *pagep, &offset);
> > > +               rc = cifs_readpage_worker(file, *pagep, &page_start);
> > >
> > >                /* we do not need to pass errors back
> > >                   e.g. if we do not have read access to the file
> > >                   because cifs_write_end will attempt synchronous writes
> > >                   -- shaggy */
> > >
> > >

Thanks guys. Yeah that is how I thought cifs_readpage_worker should
work when making that change, but obiously didn't have an eye for
details. Thanks Shaggy!