From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roman Zippel <zippel@linux-m68k.org>
Subject: Re: [PATCH 2/2] Fix journal detection on HFS+.
Date: Sun, 23 Nov 2008 05:52:00 +0100
Message-ID: <200811230552.02221.zippel@linux-m68k.org>
References: <1227240087-29413-1-git-send-email-wt@penguintechs.org> <1227240087-29413-2-git-send-email-wt@penguintechs.org> <1227240087-29413-3-git-send-email-wt@penguintechs.org>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org
To: Warren Turkal <wt@penguintechs.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from smtp-vbr9.xs4all.nl ([194.109.24.29]:3517 "EHLO
	smtp-vbr9.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753536AbYKWEwo (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 22 Nov 2008 23:52:44 -0500
In-Reply-To: <1227240087-29413-3-git-send-email-wt@penguintechs.org>
Content-Disposition: inline
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Hi,

On Friday 21. November 2008, Warren Turkal wrote:

(Sorry for taking so long to get to this.)

> +static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr)
> +{
> +	return (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED) &&
> +				vhdr->journal_info_block);
> +}

I'm curious how common it is to have the journal bit set but no journal block, 
I haven't seen this case so far.
IMO more useful would be to read the journal block and check if there is 
anything that needs to be replayed.
If you're interested in a second step you could replay the journal, it's not 
that difficult to do, it's pretty much just copying blocks around.

bye, Roman