From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: poll: allow f_op->poll to sleep, take #3
Date: Sun, 23 Nov 2008 10:34:20 +0100
Message-ID: <20081123093420.GN30453@elte.hu>
References: <E1L3oK1-0001Pz-J9@pomaz-ex.szeredi.hu> <20081122123942.GF5707@parisc-linux.org> <4927FE87.6050005@gmail.com> <20081122105356.87856d04.akpm@linux-foundation.org> <4928B162.9030404@gmail.com> <alpine.DEB.1.10.0811221831550.19456@alien.or.mcafeemobile.com> <20081123085902.GI30453@elte.hu> <49291F06.5040907@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Davide Libenzi <davidel@xmailserver.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <matthew@wil.cx>,
	Miklos Szeredi <miklos@szeredi.hu>, arjan@linux.intel.com,
	Linus Torvalds <torvalds@linux-foundation.org>,
	hch@infradead.org, rminnich@sandia.gov, ericvh@gmail.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org
To: Tejun Heo <htejun@gmail.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx2.mail.elte.hu ([157.181.151.9]:46178 "EHLO mx2.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751723AbYKWJel (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Sun, 23 Nov 2008 04:34:41 -0500
Content-Disposition: inline
In-Reply-To: <49291F06.5040907@gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>


* Tejun Heo <htejun@gmail.com> wrote:

> Ingo Molnar wrote:
> > * Davide Libenzi <davidel@xmailserver.org> wrote:
> > 
> >> On Sun, 23 Nov 2008, Tejun Heo wrote:
> >>
> >>> +static int pollwake(wait_queue_t *wait, unsigned mode, int sync, void *key)
> >>> +{
> >>> +	struct poll_wqueues *pwq = wait->private;
> >>> +	DECLARE_WAITQUEUE(dummy_wait, pwq->polling_task);
> >>> +
> >>> +	set_mb(pwq->triggered, 1);
> >>> +
> >>> +	/* perform the default wake up operation */
> >>> +	return default_wake_function(&dummy_wait, mode, sync, key);
> >>> +}
> >> Wouldn't it be nicer to un-static try_to_wake_up() (or a wrapper) 
> >> instead of setting up a fake wait queue just to use 
> >> default_wake_function(), just to wake up a task?
> > 
> > the already existing single-task-wakeup shortcut method made available 
> > by the scheduler is wake_up_process(). A number of primitives where 
> > waitqueue overhead is of concern already make use of it. 
> > (mutexes/rtmutexes and more)
> > 
> > if you need a different mode flag, then please extend the 
> > wake_up_process() family of APIs.
> 
> Well, the problem is that for wait wake up functions @mode and @sync 
> are passed as parameter and should be passed over to actual wake up 
> function as-is, if I add @mode and @sync to wake_up_process() family 
> of APIs, it's just try_to_wake_up().

_sync() is not something that should normally be done from poll 
handlers. But ->poll() handlers should all be TASK_INTERRUPTIBLE, 
right? So wake_up_process_interruptible() should be the thing you 
need?

Anyway, if you really want to pass in a state filter, you can use the 
already existing wake_up_state() method as well.

	Ingo