From: Jeff Layton <jlayton@redhat.com>
To: "Steve French" <smfrench@gmail.com>
Cc: "Nick Piggin" <npiggin@suse.de>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
pbadari@us.ibm.com,
"linux-cifs-client@lists.samba.org"
<linux-cifs-client@lists.samba.org>
Subject: Re: [linux-cifs-client] Re: fsx-linux failing with latest cifs-2.6 git tree
Date: Wed, 26 Nov 2008 06:54:18 -0500 [thread overview]
Message-ID: <20081126065418.3ffb6045@tleilax.poochiereds.net> (raw)
In-Reply-To: <524f69650811252004nfc7936bga8aa0d34ef487cd@mail.gmail.com>
On Tue, 25 Nov 2008 22:04:04 -0600
"Steve French" <smfrench@gmail.com> wrote:
> Do you know why someone added the AOP_FLAG_UNITERRUPTIBLE check in
> cifs_write_begin instead of always marking a page up to date if we are
> writing the whole page? How often would that flag be set - I only see
> it in the path which calls generic_file_buffered_write
>
> /* If we are writing a full page it will be up to date,
> no need to read from the server */
> if (len == PAGE_CACHE_SIZE && flags & AOP_FLAG_UNINTERRUPTIBLE)
>
> It seems restrictive
Good Q. This article is informative...
http://lwn.net/Articles/254856/
...so I take this to mean that when this flag isn't set you might be
able to interrupt the copy of the data to the page, and leave part of
it in an uninitialized state.
Hmm...given that, we should probably not optimize the read away at all
if that flag isn't set. Let me see about respinning that patch...
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2008-11-26 11:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081121105613.09a8cb8e@tleilax.poochiereds.net>
[not found] ` <524f69650811210820s549de2bah3181cbc0c5633091@mail.gmail.com>
[not found] ` <20081121112249.0b408b55@tleilax.poochiereds.net>
[not found] ` <524f69650811210846q7502fd99m6f4d335bb6ac1b65@mail.gmail.com>
[not found] ` <524f69650811211109w659e5decoa34a8e0f907772a3@mail.gmail.com>
[not found] ` <524f69650811211113q4fffcc70of88cb85db531c358@mail.gmail.com>
[not found] ` <1227296476.20845.8.camel@norville.austin.ibm.com>
[not found] ` <524f69650811211218v78295682lcf6dce842327b097@mail.gmail.com>
2008-11-21 20:38 ` Fwd: fsx-linux failing with latest cifs-2.6 git tree Steve French
2008-11-21 20:41 ` Dave Kleikamp
2008-11-21 21:02 ` Steve French
2008-11-21 23:44 ` Nick Piggin
2008-11-21 20:50 ` Jeff Layton
2008-11-21 22:50 ` Jeff Layton
2008-11-21 23:02 ` Dave Kleikamp
2008-11-21 23:25 ` Jeff Layton
2008-11-22 1:04 ` Steve French
2008-11-22 1:50 ` Jeff Layton
2008-11-21 23:53 ` Nick Piggin
2008-11-22 1:51 ` Jeff Layton
2008-11-22 2:02 ` Steve French
2008-11-22 4:47 ` Dave Kleikamp
2008-11-22 15:39 ` [linux-cifs-client] " Jeff Layton
2008-11-22 20:27 ` Dave Kleikamp
2008-11-23 11:57 ` Jeff Layton
2008-11-24 2:32 ` Steve French
2008-11-24 11:19 ` [linux-cifs-client] " Jeff Layton
2008-11-26 4:04 ` Steve French
2008-11-26 11:54 ` Jeff Layton [this message]
2008-11-26 12:11 ` Jeff Layton
2008-11-26 13:09 ` [linux-cifs-client] " Nick Piggin
2008-11-26 15:08 ` Jeff Layton
2008-11-26 15:23 ` Nick Piggin
2008-11-26 16:37 ` Jeff Layton
2008-11-27 8:33 ` Nick Piggin
2008-11-28 12:18 ` Jeff Layton
2008-11-30 21:44 ` Steve French
2008-11-30 22:17 ` Jeff Layton
2008-12-01 8:44 ` Nick Piggin
2008-12-01 11:28 ` Jeff Layton
2008-12-01 11:32 ` Nick Piggin
2008-12-01 11:55 ` Jeff Layton
2008-12-01 17:43 ` Steve French
2008-11-26 19:46 ` Steve French
2008-11-24 20:00 ` Dave Kleikamp
2008-11-26 13:02 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081126065418.3ffb6045@tleilax.poochiereds.net \
--to=jlayton@redhat.com \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=pbadari@us.ibm.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).