From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH 2/2] relatime: Allow making relatime the default behaviour Date: Wed, 26 Nov 2008 14:11:40 -0700 Message-ID: <20081126211140.GH25548@parisc-linux.org> References: <20081126195457.GA3541@srcf.ucam.org> <20081126195824.GB3541@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mingo@redhat.com, val.henson@gmail.com To: Matthew Garrett Return-path: Received: from palinux.external.hp.com ([192.25.206.14]:50773 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752046AbYKZVLl (ORCPT ); Wed, 26 Nov 2008 16:11:41 -0500 Content-Disposition: inline In-Reply-To: <20081126195824.GB3541@srcf.ucam.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Nov 26, 2008 at 07:58:24PM +0000, Matthew Garrett wrote: > +#define MS_NORELATIME (1<<24) /* Disable relatie even if the default */ typo Otherwise, looks good. Reviewed-by: Matthew Wilcox Instead of using __setup, could we use core_param() for these two parameters? I'm not sure that core_param are exposed in /sys or /proc anywhere ... if we could fix that, I think it'd simplify this patch enormously. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."