From: Christoph Hellwig <hch@infradead.org>
To: Matthew Garrett <mjg@redhat.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Randy Dunlap <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
mingo@redhat.com, val.henson@gmail.com, matthew@wil.cx
Subject: Re: [PATCH v3] relatime: Make relatime smarter
Date: Thu, 27 Nov 2008 12:06:15 -0500 [thread overview]
Message-ID: <20081127170615.GB14991@infradead.org> (raw)
In-Reply-To: <20081127165929.GA23366@srcf.ucam.org>
On Thu, Nov 27, 2008 at 04:59:29PM +0000, Matthew Garrett wrote:
> Make relatime smarter
>
> Allow atime to be updated once per day even with relatime. This lets
> utilities like tmpreaper (which delete files based on last access time)
> continue working. The time between atime updates can be configured at boot
> with the relatime_interval kernel argument, or at runtime through /proc
Technically it's sysctl which just happens to be exposed in /proc..
> + if (mnt->mnt_flags & MNT_RELATIME)
> + if (!relatime_need_update(inode, now))
> + goto out;
> if (timespec_equal(&inode->i_atime, &now))
Maybe rename relatime_need_update to atime_need_update and factor
this check into it?
Except for this nitpicks this seems extremly useful
next prev parent reply other threads:[~2008-11-27 17:06 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 19:54 [PATCH 1/2] relatime: Make atime updates more useful Matthew Garrett
2008-11-26 19:58 ` [PATCH 2/2] relatime: Allow making relatime the default behaviour Matthew Garrett
2008-11-26 21:11 ` Matthew Wilcox
2008-11-26 22:39 ` Randy Dunlap
2008-11-27 15:01 ` [PATCH v2 1/2] relatime: Make relatime behaviour smarter Matthew Garrett
2008-11-27 15:03 ` [PATCH v2 2/2] relatime: Allow making relatime the default behaviour Matthew Garrett
2008-11-27 15:07 ` Ingo Molnar
2008-11-27 16:03 ` Karel Zak
[not found] ` <20081127160353.GQ2961-sHeGUpI7y9L/9pzu0YdTqQ@public.gmane.org>
2008-11-27 17:30 ` Pádraig Brady
[not found] ` <492ED945.5010600-V8g9lnOeT5ydJdNcDFJN0w@public.gmane.org>
2008-11-27 17:39 ` Matthew Garrett
2008-11-27 16:35 ` Alan Cox
2008-11-27 16:47 ` Matthew Garrett
2008-11-27 16:59 ` [PATCH v3] relatime: Make relatime smarter Matthew Garrett
2008-11-27 17:06 ` Christoph Hellwig [this message]
2008-11-27 17:58 ` [PATCH v4] " Matthew Garrett
2008-11-27 22:08 ` Andreas Dilger
2008-11-27 22:35 ` Matthew Wilcox
2008-11-28 11:13 ` Jamie Lokier
2008-11-28 13:41 ` Matthew Garrett
2008-11-28 11:18 ` Jamie Lokier
2008-11-28 13:40 ` Matthew Wilcox
2008-11-28 13:47 ` Matthew Garrett
2008-12-02 11:10 ` Karel Zak
2008-12-02 16:46 ` Matthew Wilcox
2008-11-27 19:15 ` [PATCH v3] " Alan Cox
2008-11-28 11:16 ` Jamie Lokier
2008-11-28 13:45 ` Matthew Garrett
2008-11-27 17:03 ` [PATCH v2 2/2] relatime: Allow making relatime the default behaviour Christoph Hellwig
2008-11-29 8:24 ` Andrew Morton
2008-11-29 13:03 ` Matthew Wilcox
2008-11-29 13:57 ` Jörn Engel
2008-11-29 18:56 ` Jamie Lokier
2008-11-29 19:02 ` Matthew Garrett
2008-11-29 20:32 ` Andrew Morton
2008-11-29 20:38 ` Matthew Wilcox
2008-11-29 20:56 ` Andrew Morton
2008-11-29 21:41 ` Ingo Molnar
2008-11-29 20:55 ` Arjan van de Ven
2008-11-29 21:03 ` Matthew Garrett
2008-11-29 21:02 ` Matthew Garrett
2008-11-27 15:06 ` [PATCH v2 1/2] relatime: Make relatime behaviour smarter Ingo Molnar
2008-11-29 8:29 ` [PATCH 1/2] relatime: Make atime updates more useful Andrew Morton
2008-12-02 17:19 ` [PATCH] relatime: Let relatime update atime at least once per day Matthew Garrett
2008-12-13 5:26 ` Valerie Aurora Henson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081127170615.GB14991@infradead.org \
--to=hch@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@redhat.com \
--cc=mjg@redhat.com \
--cc=randy.dunlap@oracle.com \
--cc=val.henson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).