From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v3] relatime: Make relatime smarter Date: Thu, 27 Nov 2008 12:06:15 -0500 Message-ID: <20081127170615.GB14991@infradead.org> References: <20081126195457.GA3541@srcf.ucam.org> <20081126195824.GB3541@srcf.ucam.org> <492DD035.5020705@oracle.com> <20081127150126.GA20941@srcf.ucam.org> <20081127150341.GB20941@srcf.ucam.org> <20081127163535.775729bf@lxorguk.ukuu.org.uk> <20081127164754.GC22963@srcf.ucam.org> <20081127165929.GA23366@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alan Cox , Randy Dunlap , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mingo@redhat.com, val.henson@gmail.com, matthew@wil.cx To: Matthew Garrett Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:42642 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754489AbYK0RG0 (ORCPT ); Thu, 27 Nov 2008 12:06:26 -0500 Content-Disposition: inline In-Reply-To: <20081127165929.GA23366@srcf.ucam.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Nov 27, 2008 at 04:59:29PM +0000, Matthew Garrett wrote: > Make relatime smarter > > Allow atime to be updated once per day even with relatime. This lets > utilities like tmpreaper (which delete files based on last access time) > continue working. The time between atime updates can be configured at boot > with the relatime_interval kernel argument, or at runtime through /proc Technically it's sysctl which just happens to be exposed in /proc.. > + if (mnt->mnt_flags & MNT_RELATIME) > + if (!relatime_need_update(inode, now)) > + goto out; > if (timespec_equal(&inode->i_atime, &now)) Maybe rename relatime_need_update to atime_need_update and factor this check into it? Except for this nitpicks this seems extremly useful