linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@sun.com>
To: Christoph Hellwig <hch@lst.de>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] add a FMODE flag to make XFS invisible I/O less hacky
Date: Fri, 28 Nov 2008 15:58:42 -0700	[thread overview]
Message-ID: <20081128225659.GU3186@webber.adilger.int> (raw)
In-Reply-To: <20081128112402.GA32740@lst.de>

On Nov 28, 2008  12:24 +0100, Christoph Hellwig wrote:
> XFS has a mode called invisble I/O that doesn't update any of the
> timestamps.  It's used for HSM-style applications and exposed through
> the nasty open by handle ioctl.
> 
> Instead of doing directly assignment of file operations that set an
> internal flag for it add a new FMODE_INVISIBLE flag that we can check
> in the normal file operations.

Why not call this "FMODE_NOCMTIME" similar to the inode flag "S_NOCMTIME"
that already exists, and .  That makes it more clear what is being done,
instead of calling it "INVISIBLE".

It should also not be possible to skip ctime updates for non-root users,
as that provides some forensic trail if files have been modified by users.
Not sure if that is relevant here though (it looks like this is only used
internally), but worth mentioning in any case.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.


  parent reply	other threads:[~2008-11-28 22:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-28 11:24 [PATCH] add a FMODE flag to make XFS invisible I/O less hacky Christoph Hellwig
2008-11-28 11:30 ` Al Viro
2008-11-30  9:16   ` Christoph Hellwig
2008-12-02 10:19     ` Christoph Hellwig
2008-11-28 22:58 ` Andreas Dilger [this message]
2008-11-30  9:18   ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2008-12-03 17:45 Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081128225659.GU3186@webber.adilger.int \
    --to=adilger@sun.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).