From: Jeff Layton <jlayton@redhat.com>
To: "Steve French" <smfrench@gmail.com>
Cc: smfrench@austin.rr.com, linux-cifs-client@lists.samba.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 3/7] cifs: don't declare smb_vol info on the stack
Date: Sun, 30 Nov 2008 17:28:05 -0500 [thread overview]
Message-ID: <20081130172805.3eaf6cde@tupile.poochiereds.net> (raw)
In-Reply-To: <524f69650811301249l11bb05aev2cd3d40aba3c795c@mail.gmail.com>
On Sun, 30 Nov 2008 14:49:04 -0600
"Steve French" <smfrench@gmail.com> wrote:
> I have thought about this a few times, but always hesitated because I
> was hoping that eventually cifs mount option parsing could use new
> parsing functions (which would also shrink the "parse_mount_options"
> routine which we call during cifs mount), and would cause us to
> rewrite this. IIRC nfs was changed a few years ago to use the new
> mount mechanism (match_table and tokens).
>
I think we'll still have a smb_vol struct or something like it,
regardless of how we end up doing the parsing. The results of the
parsing have to be recorded somewhere. There's a similar struct for NFS
as well (nfs_parsed_mount_data). We definitely should switch to the
standard parser, but I don't think this patch will make much difference
in how that is implemented.
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2008-11-30 22:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1228070436-6063-1-git-send-email-jlayton@redhat.com>
[not found] ` <1228070436-6063-4-git-send-email-jlayton@redhat.com>
2008-11-30 20:49 ` [PATCH 3/7] cifs: don't declare smb_vol info on the stack Steve French
2008-11-30 22:28 ` Jeff Layton [this message]
2008-12-02 1:43 ` [PATCH 0/7] cifs: clean up socket creation, connection and sending (try #2) Steve French
2008-12-02 3:02 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081130172805.3eaf6cde@tupile.poochiereds.net \
--to=jlayton@redhat.com \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=smfrench@austin.rr.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).