From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH v2]: check for fops->owner in anon_inode_getfd
Date: Mon, 1 Dec 2008 09:57:16 +0100
Message-ID: <200812010957.16556.borntraeger@de.ibm.com>
References: <200811202010.00125.borntraeger@de.ibm.com> <200811272017.26719.borntraeger@de.ibm.com> <alpine.DEB.1.10.0811271139140.3147@alien.or.mcafeemobile.com>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org, Avi Kivity <avi@redhat.com>,
	kvm@vger.kernel.org
To: Davide Libenzi <davidel@xmailserver.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mtagate3.de.ibm.com ([195.212.29.152]:46660 "EHLO
	mtagate3.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750755AbYLAI5T (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 1 Dec 2008 03:57:19 -0500
In-Reply-To: <alpine.DEB.1.10.0811271139140.3147@alien.or.mcafeemobile.com>
Content-Disposition: inline
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Am Donnerstag, 27. November 2008 schrieb Davide Libenzi:
> > ===================================================================
> > --- kvm.orig/fs/anon_inodes.c
> > +++ kvm/fs/anon_inodes.c
> > @@ -79,9 +79,12 @@ int anon_inode_getfd(const char *name, c
> >  	if (IS_ERR(anon_inode_inode))
> >  		return -ENODEV;
> >  
> > +	if (fops->owner && !try_module_get(fops->owner))
> > +		return -ENOENT;
> > +
> >  	error = get_unused_fd_flags(flags);
> >  	if (error < 0)
> > -		return error;
> > +		goto err_module;
> >  	fd = error;
> >  
> >  	/*
> > @@ -128,6 +131,8 @@ err_dput:
> >  	dput(dentry);
> >  err_put_unused_fd:
> >  	put_unused_fd(fd);
> > +err_module:
> > +	module_put(fops->owner);
> >  	return error;
> >  }
> >  EXPORT_SYMBOL_GPL(anon_inode_getfd);
> 
> Looks OK to me.


Ok. Thanks. I will push this to Avi. 
Can I add a
Reviewed-by: Davide Libenzi <davidel@xmailserver.org>
to the patch?

Christian