From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] add a FMODE flag to make XFS invisible I/O less hacky Date: Tue, 2 Dec 2008 11:19:54 +0100 Message-ID: <20081202101954.GA17757@lst.de> References: <20081128112402.GA32740@lst.de> <20081128113052.GS28946@ZenIV.linux.org.uk> <20081130091603.GA3315@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org To: Al Viro Return-path: Received: from verein.lst.de ([213.95.11.210]:51378 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752503AbYLBKT7 (ORCPT ); Tue, 2 Dec 2008 05:19:59 -0500 Content-Disposition: inline In-Reply-To: <20081130091603.GA3315@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Nov 30, 2008 at 10:16:04AM +0100, Christoph Hellwig wrote: > On Fri, Nov 28, 2008 at 11:30:52AM +0000, Al Viro wrote: > > On Fri, Nov 28, 2008 at 12:24:02PM +0100, Christoph Hellwig wrote: > > > XFS has a mode called invisble I/O that doesn't update any of the > > > timestamps. It's used for HSM-style applications and exposed through > > > the nasty open by handle ioctl. > > > > > > Instead of doing directly assignment of file operations that set an > > > internal flag for it add a new FMODE_INVISIBLE flag that we can check > > > in the normal file operations. > > > > Seeing that it's similar to O_NOATIME, why not do it in O_... space? > > For now I just want to get rid of the horrible hack in XFS. Adding this > as a user-visible feature might be a good idea that those who need it > can submit. Taking about that submission, any chance I could just put in this with a flag allocated high enough to not clash in the XFS tree and then sort out things once the vfs and xfs trees get merged for 2.6.29? That's help making progress on the XFS side a lot, as there would be tons of merge conflicts there othwerwise. (compat_ioctl handling just got a big rework, touch just 2/3s of the hunks of this patch)