From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: PROBLEM: hfsplus filesystem allows opendir() on plain files Date: Sat, 6 Dec 2008 06:47:39 +0000 Message-ID: <20081206064739.GN28946@ZenIV.linux.org.uk> References: <493553C0.2090407@frey.co.nz> <20081202222111.GA2738@cynthia.pants.nu> <20081205093948.GA15714@infradead.org> <20081206063226.GB13807@cynthia.pants.nu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Damian Stewart , linux-fsdevel@vger.kernel.org To: Brad Boyer Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:35177 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751321AbYLFGrm (ORCPT ); Sat, 6 Dec 2008 01:47:42 -0500 Content-Disposition: inline In-Reply-To: <20081206063226.GB13807@cynthia.pants.nu> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Dec 05, 2008 at 10:32:26PM -0800, Brad Boyer wrote: > I personally don't care about the feature myself. I'm not sure what > good it does anyway, and I don't know of anything on Linux that > uses it. However, I also wasn't the one that added it. My original > version of hfsplus did not have any way to access them. Maybe it's > best to just remove it and see who complains about it. I do want to > point out that I don't maintain that code anymore and don't have > time to do that work myself. As far as I know, hfsplus is officially > unmaintained these days. > > Just as a side note, hfs has the same feature. The two modules are > basically the same code these days. You know what... I thought that HFS+ did not support links; looking at the source, it appears that hardlinks *are* supported and that brings all the deadlocks into the game, same as we had in reiser4 case. Which is to say, this stuff *must* go. In case of HFS it's obnoxious, but not immediately letal. In case of HFS+ it's an instant DoS.