From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Duane Griffin" Subject: [PATCH, v2] sysv: ensure link targets are NUL-terminated Date: Thu, 11 Dec 2008 22:35:32 +0000 Message-ID: <20081211223532.GD18665@dastardly.home.dghda.com> References: <1229022995-9898-2-git-send-email-duaneg@dghda.com> <1229022995-9898-3-git-send-email-duaneg@dghda.com> <1229022995-9898-4-git-send-email-duaneg@dghda.com> <1229022995-9898-5-git-send-email-duaneg@dghda.com> <1229022995-9898-6-git-send-email-duaneg@dghda.com> <1229022995-9898-7-git-send-email-duaneg@dghda.com> <1229022995-9898-8-git-send-email-duaneg@dghda.com> <1229022995-9898-9-git-send-email-duaneg@dghda.com> <1229022995-9898-10-git-send-email-duaneg@dghda.com> <1229022995-9898-11-git-send-email-duaneg@dghda.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Boaz Harrosh , hch@infradead.org To: Duane Griffin Return-path: Received: from kumera.dghda.com ([80.68.90.171]:41235 "EHLO kumera.dghda.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756040AbYLKWfh (ORCPT ); Thu, 11 Dec 2008 17:35:37 -0500 Content-Disposition: inline In-Reply-To: <1229022995-9898-11-git-send-email-duaneg@dghda.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Ensure link targets are NUL-terminated, even if corrupted on-disk. Signed-off-by: Duane Griffin --- V2: terminate when the link is read instead of every time it is followed, as suggested by Dave Kleikamp. diff --git a/fs/sysv/inode.c b/fs/sysv/inode.c index df0d435..1511228 100644 --- a/fs/sysv/inode.c +++ b/fs/sysv/inode.c @@ -163,8 +163,10 @@ void sysv_set_inode(struct inode *inode, dev_t rdev) if (inode->i_blocks) { inode->i_op = &sysv_symlink_inode_operations; inode->i_mapping->a_ops = &sysv_aops; - } else + } else { inode->i_op = &sysv_fast_symlink_inode_operations; + ((char *) SYSV_I(inode)->i_data)[inode->i_size] = '\0'; + } } else init_special_inode(inode, inode->i_mode, rdev); } -- "I never could learn to drink that blood and call it wine" - Bob Dylan