From: "Duane Griffin" <duaneg@dghda.com>
To: Duane Griffin <duaneg@dghda.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Boaz Harrosh <bharrosh@panasas.com>,
dushistov@mail.ru
Subject: [PATCH, v2] ufs: ensure link targets are NUL-terminated
Date: Thu, 11 Dec 2008 22:36:08 +0000 [thread overview]
Message-ID: <20081211223608.GE18665@dastardly.home.dghda.com> (raw)
In-Reply-To: <1229022995-9898-12-git-send-email-duaneg@dghda.com>
Ensure link targets are NUL-terminated, even if corrupted on-disk.
Signed-off-by: Duane Griffin <duaneg@dghda.com>
---
V2: terminate when the link is read instead of every time it is
followed, as suggested by Dave Kleikamp.
diff --git a/fs/ufs/inode.c b/fs/ufs/inode.c
index 39f8778..a22f64d 100644
--- a/fs/ufs/inode.c
+++ b/fs/ufs/inode.c
@@ -606,9 +606,11 @@ static void ufs_set_inode_ops(struct inode *inode)
inode->i_fop = &ufs_dir_operations;
inode->i_mapping->a_ops = &ufs_aops;
} else if (S_ISLNK(inode->i_mode)) {
- if (!inode->i_blocks)
+ if (!inode->i_blocks) {
+ char *link = UFS_I(inode)->i_u1.i_symlink;
inode->i_op = &ufs_fast_symlink_inode_operations;
- else {
+ link[inode->i_size] = '\0';
+ } else {
inode->i_op = &page_symlink_inode_operations;
inode->i_mapping->a_ops = &ufs_aops;
}
--
"I never could learn to drink that blood and call it wine" - Bob Dylan
next prev parent reply other threads:[~2008-12-11 22:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 19:16 [PATCH 0/11] make link target handling more robust Duane Griffin
[not found] ` <1229022995-9898-2-git-send-email-duaneg@dghda.com>
[not found] ` <1229022995-9898-3-git-send-email-duaneg@dghda.com>
[not found] ` <1229022995-9898-4-git-send-email-duaneg@dghda.com>
2008-12-11 19:16 ` [PATCH] ext2: ensure link targets are NULL-terminated Duane Griffin
2008-12-11 19:21 ` Matthew Wilcox
2008-12-11 20:25 ` Duane Griffin
2008-12-11 22:23 ` [PATCH, v2] ext2: ensure link targets are NUL-terminated Duane Griffin
[not found] ` <1229022995-9898-6-git-send-email-duaneg@dghda.com>
2008-12-11 22:26 ` [PATCH, v2] ext3: ensure link targets are NULL-terminated Duane Griffin
2008-12-12 3:32 ` Andrew Morton
2008-12-12 9:40 ` Duane Griffin
2008-12-12 10:19 ` Duane Griffin
2008-12-16 0:09 ` Andrew Morton
[not found] ` <1229022995-9898-7-git-send-email-duaneg@dghda.com>
2008-12-11 22:27 ` [PATCH, v2] ext4: ensure link targets are NUL-terminated Duane Griffin
[not found] ` <1229022995-9898-8-git-send-email-duaneg@dghda.com>
[not found] ` <1229022995-9898-9-git-send-email-duaneg@dghda.com>
2008-12-11 20:06 ` [PATCH] JFS: ensure link targets are NULL-terminated Dave Kleikamp
2008-12-11 20:34 ` Duane Griffin
[not found] ` <1229022995-9898-10-git-send-email-duaneg@dghda.com>
[not found] ` <1229022995-9898-11-git-send-email-duaneg@dghda.com>
2008-12-11 22:35 ` [PATCH, v2] sysv: ensure link targets are NUL-terminated Duane Griffin
2008-12-15 10:12 ` Al Viro
[not found] ` <1229022995-9898-12-git-send-email-duaneg@dghda.com>
2008-12-11 22:36 ` Duane Griffin [this message]
2008-12-14 21:12 ` [PATCH, v2] ufs: " Evgeniy Dushistov
2008-12-11 22:37 ` [PATCH, v2] freevxfs: " Duane Griffin
2008-12-11 19:32 ` [PATCH] eCryptfs: check readlink result was not an error before using it Michael Halcrow
2008-12-12 1:48 ` Tim Gardner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081211223608.GE18665@dastardly.home.dghda.com \
--to=duaneg@dghda.com \
--cc=bharrosh@panasas.com \
--cc=dushistov@mail.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).