From: Andrea Arcangeli <aarcange@redhat.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
Tim LaBerge <tim.laberge@quantum.com>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
Wang Chen <wangchen@cn.fujitsu.com>
Subject: Re: Corruption with O_DIRECT and unaligned user buffers
Date: Fri, 19 Dec 2008 21:34:45 +0100 [thread overview]
Message-ID: <20081219203445.GB6383@random.random> (raw)
In-Reply-To: <494B8AD5.3090901@cn.fujitsu.com>
On Fri, Dec 19, 2008 at 07:51:49PM +0800, Li Zefan wrote:
> > diff -ur rhel-5.2/kernel/fork.c x/kernel/fork.c
> > --- rhel-5.2/kernel/fork.c 2008-07-10 17:26:43.000000000 +0200
> > +++ x/kernel/fork.c 2008-12-18 15:57:31.000000000 +0100
> > @@ -368,7 +368,7 @@
> > rb_parent = &tmp->vm_rb;
> >
> > mm->map_count++;
> > - retval = copy_page_range(mm, oldmm, mpnt);
> > + retval = copy_page_range(mm, oldmm, tmp);
> >
>
> Could you explain a bit why this change is needed?
This change is needed to pass the child vma (not the parent vma) to
handle_mm_fault. We run handle_mm_fault on the child not on the
parent, so the vma passed to handle_mm_fault has to be the one of the
child obviously. It won't make a difference for the other users of the
vma because both vma are basically the same. Nick did it btw.
prev parent reply other threads:[~2008-12-19 20:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 17:04 Corruption with O_DIRECT and unaligned user buffers Tim LaBerge
2008-11-19 4:25 ` Nick Piggin
2008-11-19 6:52 ` Nick Piggin
2008-11-19 16:58 ` Andrea Arcangeli
2008-12-18 15:29 ` Andrea Arcangeli
2008-12-19 2:21 ` KAMEZAWA Hiroyuki
2008-12-19 5:06 ` KAMEZAWA Hiroyuki
2008-12-19 6:34 ` KOSAKI Motohiro
2008-12-20 16:02 ` Andrea Arcangeli
2008-12-19 7:19 ` KAMEZAWA Hiroyuki
2008-12-19 7:44 ` Li Zefan
2008-12-19 8:45 ` Li Zefan
2008-12-19 20:27 ` Andrea Arcangeli
2008-12-20 15:55 ` Andrea Arcangeli
2008-12-19 11:51 ` Li Zefan
2008-12-19 12:14 ` KOSAKI Motohiro
2008-12-19 12:58 ` Hugh Dickins
2008-12-19 20:34 ` Andrea Arcangeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081219203445.GB6383@random.random \
--to=aarcange@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=nickpiggin@yahoo.com.au \
--cc=tim.laberge@quantum.com \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).