From: Arjan van de Ven <arjan@infradead.org>
To: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: Grissiom <chaos.proton@gmail.com>,
linux-kernel@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: "BUG: scheduling while atomic: pdflush/30/0x00000002" in latest git
Date: Thu, 8 Jan 2009 07:21:11 -0800 [thread overview]
Message-ID: <20090108072111.1ebadebd@infradead.org> (raw)
In-Reply-To: <1231425472.21528.13.camel@norville.austin.ibm.com>
On Thu, 08 Jan 2009 08:37:52 -0600
Dave Kleikamp <shaggy@linux.vnet.ibm.com> wrote:
> Adding cc:lix-fsdevel
>
> On Thu, 2009-01-08 at 16:07 +0800, Grissiom wrote:
> > When I using the latest git version, I occasionally got this in
> > dmesg:
> >
> > [ 2008.237234] BUG: scheduling while atomic: pdflush/30/0x00000002
> > [ 2008.237240] 2 locks held by pdflush/30:
> > [ 2008.237244] #0: (mutex){--..}, at: [<c01a57a1>]
> > sync_filesystems+0x11/0x120 [ 2008.237258] #1: (sb_lock){--..},
> > at: [<c01a57ab>] sync_filesystems+0x1b/0x120
> > [ 2008.237277] Modules linked in: fuse ricoh_mmc b43
> > [ 2008.237288] Pid: 30, comm: pdflush Not tainted
> > 2.6.28-g14-rfkill-nophy-ledon-07485-g9e42d0c #62
> > [ 2008.237294] Call Trace:
> > [ 2008.237303] [<c04d7576>] schedule+0x326/0x8e0
> > [ 2008.237311] [<c01500d3>] __lock_acquire+0x293/0xa20
> > [ 2008.237321] [<c014e307>] mark_held_locks+0x67/0x80
> > [ 2008.237330] [<c04da58c>] _spin_unlock_irqrestore+0x4c/0x60
> > [ 2008.237339] [<c014e519>] trace_hardirqs_on_caller+0x149/0x1a0
> > [ 2008.237351] [<c0143d55>]
> > async_synchronize_cookie_special+0xb5/0x140 [ 2008.237362]
> > [<c013e1a0>] autoremove_wake_function+0x0/0x40 [ 2008.237372]
> > [<c01a57fc>] sync_filesystems+0x6c/0x120 [ 2008.237381]
> > [<c017ee90>] pdflush+0x0/0x1e0 [ 2008.237392] [<c01c0b90>]
> > do_sync+0x20/0x60 [ 2008.237402] [<c01c0bda>] sys_sync+0xa/0x10
> > [ 2008.237412] [<c017ef9e>] pdflush+0x10e/0x1e0
> > [ 2008.237420] [<c014e519>] trace_hardirqs_on_caller+0x149/0x1a0
> > [ 2008.237429] [<c017de80>] laptop_flush+0x0/0x10
> > [ 2008.237437] [<c013dea2>] kthread+0x42/0x70
> > [ 2008.237444] [<c013de60>] kthread+0x0/0x70
> > [ 2008.237452] [<c0103c03>] kernel_thread_helper+0x7/0x14
> > (repeat some times)
> >
>
> The offender is
> http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=efaee192
>
> async_synchronize_full_special() shouldn't be called while holding a
> spinlock, sb_lock.
>
> I think this patch should fix it. Arjan, would this work?
yeah it will
woops/
next prev parent reply other threads:[~2009-01-08 15:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a0adeea50901080007q5a3ed5c8y5a744ce37e677325@mail.gmail.com>
2009-01-08 14:37 ` "BUG: scheduling while atomic: pdflush/30/0x00000002" in latest git Dave Kleikamp
2009-01-08 15:21 ` Arjan van de Ven [this message]
2009-01-08 15:46 ` [PATCH] async: Don't call async_synchronize_full_special() while holding sb_lock Dave Kleikamp
2009-01-08 22:50 ` Dave Chinner
2009-01-08 22:51 ` Arjan van de Ven
2009-01-09 0:32 ` Alan Cox
2009-01-09 0:38 ` Arjan van de Ven
2009-01-09 1:40 ` Dave Chinner
2009-01-09 4:45 ` Arjan van de Ven
2009-01-09 8:22 ` Dave Chinner
2009-01-09 15:09 ` Chris Mason
2009-01-12 2:31 ` Jamie Lokier
2009-01-12 3:54 ` Arjan van de Ven
2009-01-12 7:55 ` Dave Chinner
2009-01-12 7:48 ` Dave Chinner
2009-01-09 12:31 ` Evgeniy Polyakov
2009-01-09 5:18 ` "BUG: scheduling while atomic: pdflush/30/0x00000002" in latest git Grissiom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090108072111.1ebadebd@infradead.org \
--to=arjan@infradead.org \
--cc=chaos.proton@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaggy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).