From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH] async: Don't call async_synchronize_full_special()
	while holding sb_lock
Date: Fri, 9 Jan 2009 09:50:50 +1100
Message-ID: <20090108225050.GL9448@disturbed>
References: <a0adeea50901080007q5a3ed5c8y5a744ce37e677325@mail.gmail.com> <1231425472.21528.13.camel@norville.austin.ibm.com> <20090108072111.1ebadebd@infradead.org> <1231429591.27353.14.camel@norville.austin.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Grissiom <chaos.proton@gmail.com>, linux-kernel@vger.kernel.org,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Arjan van de Ven <arjan@linux.intel.com>
To: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from ipmail05.adl2.internode.on.net ([203.16.214.145]:44797 "EHLO
	ipmail05.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1763175AbZAHWuz (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 8 Jan 2009 17:50:55 -0500
Content-Disposition: inline
In-Reply-To: <1231429591.27353.14.camel@norville.austin.ibm.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Jan 08, 2009 at 09:46:31AM -0600, Dave Kleikamp wrote:
> sync_filesystems() shouldn't be calling async_synchronize_full_special
> while holding a spinlock.  The second while loop in that function is the
> right place for this anyway.

Out of curiousity, what on earth does
async_synchronize_full_special() do and why does it need to be in
sync_filesystems()?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com