From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: Re: [PATCH] cifs: remove dnotify thread code Date: Fri, 9 Jan 2009 13:07:57 -0500 Message-ID: <20090109130757.11ec9d81@tleilax.poochiereds.net> References: <1231424128-5598-1-git-send-email-jlayton@redhat.com> <524f69650901080623s228c343eka791c089c878167@mail.gmail.com> <20090109000708.GC12848@shareable.org> <524f69650901081932m2912ab73x147221f721194f8@mail.gmail.com> <20090109063318.04f260d1@tleilax.poochiereds.net> <524f69650901090818w7f367832vb9d0979714c3c609@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "Jamie Lokier" , linux-cifs-client@lists.samba.org, linux-fsdevel@vger.kernel.org To: "Steve French" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:48206 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752848AbZAISII (ORCPT ); Fri, 9 Jan 2009 13:08:08 -0500 In-Reply-To: <524f69650901090818w7f367832vb9d0979714c3c609@mail.gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, 9 Jan 2009 10:18:28 -0600 "Steve French" wrote: > On Fri, Jan 9, 2009 at 5:33 AM, Jeff Layton wrote: > > On Thu, 8 Jan 2009 21:32:09 -0600 > > "Steve French" wrote: > > This patch doesn't remove any capability of the current code. It just > > gets rid of this kthread that doesn't do anything useful. There's > > nothing stopping us from putting it back later once we have working dir > > notification, but until then it's just doing unnecessary wakeups. > Al's patch removes the ability for a network or cluster file system to > handle directory change notification in the future ... (AFAIK KDE, > GNOME still use this fcntl) so we won't be able to fix the fcntl to > work where it matters most (network or cluster environments) in the > future without reverting the patch. > Right. By "this patch", I meant the one that I sent. Al's concerns seem valid though. You may be able to convince him to add back in a dir_notify type interface to the VFS later but I imagine it will need some redesign to address the problems he noted. -- Jeff Layton