From mboxrd@z Thu Jan  1 00:00:00 1970
From: Evgeniy Polyakov <zbr@ioremap.net>
Subject: Re: [4/9] pohmelfs: directory operations.
Date: Wed, 14 Jan 2009 04:31:40 +0300
Message-ID: <20090114013140.GA3907@ioremap.net>
References: <a37615150901131643m3e46d82albba5366533671b40@mail.gmail.com> <20090114010719.GC1705@ioremap.net> <a37615150901131728v3f27bf01le18c5640cb38a30e@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org
To: Yehuda Sadeh Weinraub <yehudasa@gmail.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from broadrack.ru ([195.178.208.66]:60207 "EHLO tservice.net.ru"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754215AbZANBbm (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 13 Jan 2009 20:31:42 -0500
Content-Disposition: inline
In-Reply-To: <a37615150901131728v3f27bf01le18c5640cb38a30e@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Jan 13, 2009 at 05:28:29PM -0800, Yehuda Sadeh Weinraub (yehudasa@gmail.com) wrote:
> > They should be implemented already in the change attribute code.
> > Attribute changes are flushed at writeback time or on server's demand.
> >
> ok, might be that the following is the problem:
> 
> int pohmelfs_setattr(struct dentry *dentry, struct iattr *attr)
> {
> ...
>         if (!(psb->state_flags & POHMELFS_FLAGS_XATTR))
>                 return -EOPNOTSUPP;
> 
> 
> Probably this test should be only on setxattr?

Definitely :)
It should be moved there. Thanks for spotting this.

-- 
	Evgeniy Polyakov