From: Jamie Lokier <jamie@shareable.org>
To: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>,
akpm@linux-foundation.org, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ext2/3/4: change i_mutex usage on lseek
Date: Thu, 15 Jan 2009 13:01:54 +0000 [thread overview]
Message-ID: <20090115130154.GA32368@shareable.org> (raw)
In-Reply-To: <1231993950.9468.8.camel@norville.austin.ibm.com>
Dave Kleikamp wrote:
> Is there any reason you couldn't have just changed generic_file_llseek()
> to do this rather than making identical changes to the individual file
> systems. I would think this optimization would be safe for any file
> system.
Is it safe on 32-bit systems where 64-bit updates are not atomic?
You may say that doing multiple parallel lseek() calls is undefined
behaviour, so it's ok to end up with file position that none of the
individual lseek() calls asked for.
But if it's undefined behaviour, no programs should be doing parallel
lseek() calls on the same open file, so why optimise it at all?
-- Jamie
next prev parent reply other threads:[~2009-01-15 13:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 0:32 [PATCH] ext2/3/4: change i_mutex usage on lseek Hisashi Hifumi
2009-01-15 4:32 ` Dave Kleikamp
2009-01-15 4:40 ` Hisashi Hifumi
2009-01-15 13:01 ` Jamie Lokier [this message]
2009-01-15 13:35 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090115130154.GA32368@shareable.org \
--to=jamie@shareable.org \
--cc=akpm@linux-foundation.org \
--cc=hifumi.hisashi@oss.ntt.co.jp \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shaggy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).