From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [linux-dvb] compiling on 2.6.28 broken? Date: Fri, 16 Jan 2009 09:23:54 +1100 Message-ID: <20090115222354.GG8071@disturbed> References: <20090112162337.318dd61d.akpm@linux-foundation.org> <20090113184755.87720@gmx.net> <20090113105947.9e774b69.akpm@linux-foundation.org> <20090113191757.74290@gmx.net> <20090113113700.776a94b5.akpm@linux-foundation.org> <20090113203843.GJ29283@parisc-linux.org> <1231957750.8269.28.camel@think.oraclecorp.com> <496E56EB.2030301@gmx.de> <20090114223016.GY8071@disturbed> <496F9174.5080907@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Chris Mason , Matthew Wilcox , Andrew Morton , rjw@sisk.pl, HWerner4@gmx.de, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mchehab@infradead.org To: wk Return-path: Received: from ipmail04.adl2.internode.on.net ([203.16.214.57]:51343 "EHLO ipmail04.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935702AbZAOWX7 (ORCPT ); Thu, 15 Jan 2009 17:23:59 -0500 Content-Disposition: inline In-Reply-To: <496F9174.5080907@gmx.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Jan 15, 2009 at 08:41:40PM +0100, wk wrote: > Dave Chinner wrote: >> It's obviously the regression fixed by: >> >> http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/xfs.git;a=commit;h=15440319767942a363f282d6585303d3d75088ba >> >> It needs to be pushed to Linus, then into 2.6.28-stable. > > Yes, that solves the problems as expected. But may i kindly ask the xfs > fs developers to put some more readable patch here, > so that its better understandable by looking at the source code? I think > some macro would be better here, for example i used > > #define TRUNC_TO_SIGNED32(x) (x & 0x7FFFFFFF) > > inside xfs.h and replaced all "foo & 0x7fffffff" with > "TRUNC_TO_SIGNED32(foo)". >>From the commit description: "The patch below is a dumb version of just putting back the masking, to make sure we have the same behavior as in 2.6.27 and earlier. I will work on a better and cleaner fix for 2.6.30." And in more detail, read the review thread: http://oss.sgi.com/archives/xfs/2008-12/msg01168.html Cheers, Dave. -- Dave Chinner david@fromorbit.com