From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Subject: Re: [Patch] NULL pointer deref with corrupted squashfs image Date: Tue, 20 Jan 2009 11:47:02 -0700 Message-ID: <20090120184702.GB30203@smtp.west.cox.net> References: <20090113124027.GB16333@alice> <20090116174525.GA31869@alice> <20090116190725.GA19453@logfs.org> <20090116230700.GP6710@smtp.west.cox.net> <20090117134916.GA29641@logfs.org> <20090120163957.GA21339@alice> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: =?iso-8859-1?Q?J=F6rn?= Engel , phillip@lougher.demon.co.uk, linux-fsdevel@vger.kernel.org, jacmet@sunsite.dk, rpurdie@rpsys.net, linuxppc-dev@ozlabs.org, chris@zankel.net To: Eric Sesterhenn Return-path: Received: from fed1rmmtao102.cox.net ([68.230.241.44]:38956 "EHLO fed1rmmtao102.cox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753544AbZATTJE (ORCPT ); Tue, 20 Jan 2009 14:09:04 -0500 Content-Disposition: inline In-Reply-To: <20090120163957.GA21339@alice> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Jan 20, 2009 at 05:47:14PM +0100, Eric Sesterhenn wrote: > * J=F6rn Engel (joern@logfs.org) wrote: > > On Fri, 16 January 2009 16:07:00 -0700, Tom Rini wrote: > > >=20 > > > Sounds like a plan to me, except maybe zlib_inflate_unsafe() and = a > > > comment above the wrapper saying what/why is going on? > >=20 > > Eric, will you do the honors? Since you did all the hard work befo= re, > > you derserve the fame as well. :) >=20 > Since I am not sure either about xtensa I added chris to the cc list. How about we just change all callers from arch/*/boot to use the _unsaf= e version? Then.. > +/* > + These two wrappers decide wheter strm->next_out gets checked for= NULL. > + The zlib_inflate_unsafe() version got added because the PPC zIma= ge > + gets extracted to memory address 0 and therefore > + we avoid this check for zlib_inflate_unsafe() These two wrappers decide wheter strm->next_out gets checked for NULL. The zlib_inflate_unsafe() version is primarily used in the pre-Linux 'boot' directory code to allow for extraction to memory address 0 and therefore we avoid this check. --=20 Tom Rini -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html