From: MinChan Kim <minchan.kim@gmail.com>
To: Nick Piggin <npiggin@suse.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-fsdevel@vger.kernel.org,
Linux Memory Management List <linux-mm@kvack.org>,
mingo@redhat.com
Subject: Re: [patch][rfc] lockdep: annotate reclaim context (__GFP_NOFS)
Date: Wed, 21 Jan 2009 17:00:39 +0900 [thread overview]
Message-ID: <20090121080039.GB17969@barrios-desktop> (raw)
In-Reply-To: <20090121071239.GL24891@wotan.suse.de>
Hi, Nick.
> Index: linux-2.6/mm/slob.c
> ===================================================================
> --- linux-2.6.orig/mm/slob.c
> +++ linux-2.6/mm/slob.c
> @@ -464,6 +464,8 @@ void *__kmalloc_node(size_t size, gfp_t
> unsigned int *m;
> int align = max(ARCH_KMALLOC_MINALIGN, ARCH_SLAB_MINALIGN);
>
> + lockdep_trace_alloc(flags);
> +
> if (size < PAGE_SIZE - align) {
> if (!size)
> return ZERO_SIZE_PTR;
> @@ -569,6 +571,8 @@ void *kmem_cache_alloc_node(struct kmem_
> {
> void *b;
>
> + lockdep_trace_alloc(flags);
> +
> if (c->size < PAGE_SIZE)
> b = slob_alloc(c->size, flags, c->align, node);
> else
> Index: linux-2.6/mm/slub.c
> ===================================================================
> --- linux-2.6.orig/mm/slub.c
> +++ linux-2.6/mm/slub.c
> @@ -1596,6 +1596,7 @@ static __always_inline void *slab_alloc(
> unsigned long flags;
> unsigned int objsize;
>
> + lockdep_trace_alloc(flags);
Probably, not flags but gfpflags ?
> might_sleep_if(gfpflags & __GFP_WAIT);
>
> if (should_failslab(s->objsize, gfpflags))
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kinds Regards,
MinChan Kim
prev parent reply other threads:[~2009-01-21 8:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 8:39 [patch][rfc] lockdep: annotate reclaim context (__GFP_NOFS) Nick Piggin
2009-01-20 10:29 ` Peter Zijlstra
2009-01-20 14:40 ` Nick Piggin
2009-01-21 7:12 ` Nick Piggin
2009-01-21 8:00 ` MinChan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090121080039.GB17969@barrios-desktop \
--to=minchan.kim@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=npiggin@suse.de \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).