From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: smfrench@gmail.com, linux-fsdevel@vger.kernel.org,
linux-cifs-client@lists.samba.org, linux-kernel@vger.kernel.org
Subject: Re: [linux-cifs-client] [PATCH] cifs: wrap cifs_dnotify_thread in CONFIG_BROKEN
Date: Thu, 22 Jan 2009 16:06:55 -0500 [thread overview]
Message-ID: <20090122210655.GA6065@infradead.org> (raw)
In-Reply-To: <1232642078-9717-1-git-send-email-jlayton@redhat.com>
On Thu, Jan 22, 2009 at 11:34:38AM -0500, Jeff Layton wrote:
> This thread never actually did anything useful, so comment it out by
> #ifdef'ing it in CONFIG_BROKEN. My preference would be to remove it
> altogether, but it's not my call.
Please just kill it. It's not only useless but also ugly, so keeping it
around it a double disservice to the mother nature.
next prev parent reply other threads:[~2009-01-22 21:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 16:34 [PATCH] cifs: wrap cifs_dnotify_thread in CONFIG_BROKEN Jeff Layton
2009-01-22 21:06 ` Christoph Hellwig [this message]
2009-01-22 23:13 ` [linux-cifs-client] " Steve French
2009-01-22 23:31 ` Jeff Layton
2009-01-22 23:41 ` Steve French
2009-01-22 23:56 ` Steve French
2009-01-23 1:17 ` Jeff Layton
2009-01-23 0:13 ` [linux-cifs-client] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090122210655.GA6065@infradead.org \
--to=hch@infradead.org \
--cc=jlayton@redhat.com \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).