From: Evgeniy Polyakov <zbr@ioremap.net>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: David Howells <dhowells@redhat.com>,
Trond Myklebust <trond.myklebust@fys.uio.no>,
linux-fsdevel@vger.kernel.org
Subject: Re: NFS/credentials leak in 2.6.29-rc1
Date: Tue, 27 Jan 2009 12:26:59 +0300 [thread overview]
Message-ID: <20090127092659.GA2646@ioremap.net> (raw)
In-Reply-To: <20090127004955.GF20604@fieldses.org>
On Mon, Jan 26, 2009 at 07:49:55PM -0500, J. Bruce Fields (bfields@fieldses.org) wrote:
> > With additional put_cred, i.e.:
> >
> > put_cred(override_creds(new));
> > put_cred(new);
> > return 0;
> >
> > I got following fun tcpdump and failed mount (it stuck, but can be interrupted):
>
> I'm not able to reproduce this.
>
> Have you been able to reproduce this consistently? Any further results?
Yes, I can easily reproduce it with the tree I work with.
But I will update to the latest git soon (likely today) and rerun the
tests, so it may happen that rc1-rc2 frame fixed the issue at least
partially. I can also turn on some debugging options if needed.
> If not, I'm tempted to assume you're seeing some unrelated bug.
>
> David, can you ACK the additional put_cred()?
--
Evgeniy Polyakov
next prev parent reply other threads:[~2009-01-27 9:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 11:46 NFS/credentials leak in 2.6.29-rc1 Evgeniy Polyakov
2009-01-20 13:37 ` Trond Myklebust
2009-01-20 13:49 ` Evgeniy Polyakov
2009-01-20 15:11 ` J. Bruce Fields
2009-01-20 15:23 ` Evgeniy Polyakov
2009-01-20 23:53 ` J. Bruce Fields
2009-01-21 12:23 ` David Howells
2009-01-21 12:37 ` Evgeniy Polyakov
2009-01-21 22:39 ` J. Bruce Fields
2009-01-21 22:46 ` Evgeniy Polyakov
2009-01-21 23:18 ` J. Bruce Fields
2009-01-21 23:31 ` Evgeniy Polyakov
2009-01-27 0:49 ` J. Bruce Fields
2009-01-27 9:26 ` Evgeniy Polyakov [this message]
2009-01-27 22:07 ` J. Bruce Fields
2009-01-29 14:37 ` Evgeniy Polyakov
2009-01-29 18:52 ` J. Bruce Fields
2009-01-29 19:00 ` Evgeniy Polyakov
2009-02-05 13:22 ` David Howells
2009-02-05 17:21 ` J. Bruce Fields
2009-01-21 13:17 ` David Howells
2009-01-21 13:18 ` Evgeniy Polyakov
2009-01-21 22:37 ` J. Bruce Fields
2009-01-22 7:08 ` David Howells
2009-01-22 16:43 ` J. Bruce Fields
2009-01-20 21:44 ` David Howells
2009-01-21 22:42 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090127092659.GA2646@ioremap.net \
--to=zbr@ioremap.net \
--cc=bfields@fieldses.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).