From mboxrd@z Thu Jan 1 00:00:00 1970 From: Evgeniy Polyakov Subject: Re: NFS/credentials leak in 2.6.29-rc1 Date: Tue, 27 Jan 2009 12:26:59 +0300 Message-ID: <20090127092659.GA2646@ioremap.net> References: <20090120235341.GA29017@fieldses.org> <20090120114649.GA15832@ioremap.net> <20090120151125.GB24266@fieldses.org> <20090120152304.GA28592@ioremap.net> <21428.1232540589@redhat.com> <20090121123728.GA1739@ioremap.net> <20090127004955.GF20604@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Howells , Trond Myklebust , linux-fsdevel@vger.kernel.org To: "J. Bruce Fields" Return-path: Received: from genesysrack.ru ([195.178.208.66]:59444 "EHLO tservice.net.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbZA0J1H (ORCPT ); Tue, 27 Jan 2009 04:27:07 -0500 Content-Disposition: inline In-Reply-To: <20090127004955.GF20604@fieldses.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jan 26, 2009 at 07:49:55PM -0500, J. Bruce Fields (bfields@fieldses.org) wrote: > > With additional put_cred, i.e.: > > > > put_cred(override_creds(new)); > > put_cred(new); > > return 0; > > > > I got following fun tcpdump and failed mount (it stuck, but can be interrupted): > > I'm not able to reproduce this. > > Have you been able to reproduce this consistently? Any further results? Yes, I can easily reproduce it with the tree I work with. But I will update to the latest git soon (likely today) and rerun the tests, so it may happen that rc1-rc2 frame fixed the issue at least partially. I can also turn on some debugging options if needed. > If not, I'm tempted to assume you're seeing some unrelated bug. > > David, can you ACK the additional put_cred()? -- Evgeniy Polyakov