From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 05/16] vfs: Use lowercase names of quota functions Date: Tue, 27 Jan 2009 18:35:40 +0100 Message-ID: <20090127173540.GF8289@duck.suse.cz> References: <1233074929-12277-1-git-send-email-jack@suse.cz> <1233074929-12277-2-git-send-email-jack@suse.cz> <1233074929-12277-3-git-send-email-jack@suse.cz> <1233074929-12277-4-git-send-email-jack@suse.cz> <1233074929-12277-5-git-send-email-jack@suse.cz> <1233074929-12277-6-git-send-email-jack@suse.cz> <20090127171323.GA14429@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, Alexander Viro To: Christoph Hellwig Return-path: Received: from styx.suse.cz ([82.119.242.94]:43695 "EHLO mail.suse.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753232AbZA0Rfm (ORCPT ); Tue, 27 Jan 2009 12:35:42 -0500 Content-Disposition: inline In-Reply-To: <20090127171323.GA14429@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue 27-01-09 12:13:23, Christoph Hellwig wrote: > On Tue, Jan 27, 2009 at 05:48:38PM +0100, Jan Kara wrote: > > Use lowercase names of quota functions instead of old uppercase ones. > > Looking over this again I think the vfs_ names are a really bad choice. > The normal use for vfs_ are higher level functions that call into > specific filesystems, which these aren't really. What about just > striping out that vfs_ prefix first? Actually, these vfs_dq_ functions are usually just wrappers like: static inline void vfs_dq_init(struct inode *inode) { BUG_ON(!inode->i_sb); if (sb_any_quota_active(inode->i_sb) && !IS_NOQUOTA(inode)) inode->i_sb->dq_op->initialize(inode, -1); } where ->initialize either leads to a filesystem specified callback or to generic quota init function. So this seems to reasonably match your description above... But if this still has not convinced you ;), I can change all these quota functions to have names starting with dq_. That should not clash with anything else. But I'm not very enthusiastic about this change (cleanups are so boring...). Honza -- Jan Kara SUSE Labs, CR