From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 05/16] vfs: Use lowercase names of quota functions
Date: Wed, 28 Jan 2009 12:19:15 -0500
Message-ID: <20090128171915.GA11117@infradead.org>
References: <1233074929-12277-1-git-send-email-jack@suse.cz> <1233074929-12277-2-git-send-email-jack@suse.cz> <1233074929-12277-3-git-send-email-jack@suse.cz> <1233074929-12277-4-git-send-email-jack@suse.cz> <1233074929-12277-5-git-send-email-jack@suse.cz> <1233074929-12277-6-git-send-email-jack@suse.cz> <20090127171323.GA14429@infradead.org> <20090127173540.GF8289@duck.suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-fsdevel@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:40996 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751356AbZA1RTR (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 28 Jan 2009 12:19:17 -0500
Content-Disposition: inline
In-Reply-To: <20090127173540.GF8289@duck.suse.cz>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Jan 27, 2009 at 06:35:40PM +0100, Jan Kara wrote:
> On Tue 27-01-09 12:13:23, Christoph Hellwig wrote:
> > On Tue, Jan 27, 2009 at 05:48:38PM +0100, Jan Kara wrote:
> > > Use lowercase names of quota functions instead of old uppercase ones.
> > 
> > Looking over this again I think the vfs_ names are a really bad choice.
> > The normal use for vfs_ are higher level functions that call into
> > specific filesystems, which these aren't really.  What about just
> > striping out that vfs_ prefix first?
>   Actually, these vfs_dq_ functions are usually just wrappers like:
> 
> static inline void vfs_dq_init(struct inode *inode)
> {
>         BUG_ON(!inode->i_sb);
>         if (sb_any_quota_active(inode->i_sb) && !IS_NOQUOTA(inode))
>                 inode->i_sb->dq_op->initialize(inode, -1);
> }
> 
>   where ->initialize either leads to a filesystem specified callback or to
> generic quota init function. So this seems to reasonably match your
> description above...
>   But if this still has not convinced you ;), I can change all these quota
> functions to have names starting with dq_. That should not clash with
> anything else. But I'm not very enthusiastic about this change (cleanups are
> so boring...).

Hmm, seems you're right - I must have been confused when looking at it.

Changing away from the weird uppercase names defintively is a good
thing.

Although for the ops inside the filesystem it might be better to just
call into the lowlevel operation instead of the vfs_ helper as we know
what we want, no?