From mboxrd@z Thu Jan  1 00:00:00 1970
From: "J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: NFS/credentials leak in 2.6.29-rc1
Date: Thu, 29 Jan 2009 13:52:53 -0500
Message-ID: <20090129185253.GF26823@fieldses.org>
References: <20090120235341.GA29017@fieldses.org> <20090120114649.GA15832@ioremap.net> <20090120151125.GB24266@fieldses.org> <20090120152304.GA28592@ioremap.net> <21428.1232540589@redhat.com> <20090121123728.GA1739@ioremap.net> <20090127004955.GF20604@fieldses.org> <20090127092659.GA2646@ioremap.net> <20090127220735.GD9151@fieldses.org> <20090129143753.GA28669@ioremap.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Howells <dhowells@redhat.com>,
	Trond Myklebust <trond.myklebust@fys.uio.no>,
	linux-fsdevel@vger.kernel.org
To: Evgeniy Polyakov <zbr@ioremap.net>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail.fieldses.org ([141.211.133.115]:41131 "EHLO
	pickle.fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751367AbZA2SxC (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 29 Jan 2009 13:53:02 -0500
Content-Disposition: inline
In-Reply-To: <20090129143753.GA28669@ioremap.net>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Jan 29, 2009 at 05:37:53PM +0300, Evgeniy Polyakov wrote:
> On Tue, Jan 27, 2009 at 05:07:35PM -0500, J. Bruce Fields (bfields@fieldses.org) wrote:
> > I took a closer look at the tcpdump output.  Those numbers aren't port
> > numbers, they're rpc xid's: see "NFS Requests and Replies" in the
> > "OUTPUT FORMAT" section of the tcpdump man page.  Or compare the output
> > of tcpdump with wireshark's output.
> 
> Yup, they are definitely not network ports :)
> 
> > That still doesn't explain why you were seeing a mount hang--but some
> > network or other configuration problem may be the most likely
> > explanation.
> 
> I've rerun the tests with the latest git to date and I do not observe
> neither leak (with credential patch applied) nor mount fail, so please
> put the patch into the tree.

Thanks for the confirmation--but I jumped the gun and already submitted
them...

> Feel free to add my signed/acked/tested/whatevered if needed :)

... and forgot to credit you--sorry, I should have.  Thanks again for
catching the problem!

--b.