From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH 4/9] Amiga SmartFileSystem Date: Mon, 9 Feb 2009 01:40:13 -0700 Message-ID: <20090209084013.GM31509@parisc-linux.org> References: <187c6cc60902082255l1475ac1al80b8fc7e206b0bf2@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: Pavel Fedin Return-path: Received: from palinux.external.hp.com ([192.25.206.14]:49385 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750946AbZBIIkO (ORCPT ); Mon, 9 Feb 2009 03:40:14 -0500 Content-Disposition: inline In-Reply-To: <187c6cc60902082255l1475ac1al80b8fc7e206b0bf2@mail.gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Feb 09, 2009 at 09:55:00AM +0300, Pavel Fedin wrote: > + if ((errorcode = asfs_allocadminspace(sb, > &newbcontblock)) == 0 && (bh = asfs_getzeroblk(sb, newbcontblock))) { > + struct fsBNodeContainer *bnc = (void > *) bh->b_data; > + struct fsBNodeContainer *bncparent = > (void *) bhparent->b_data; > + struct BTreeContainer *btcparent = > &bncparent->btc; The wrapping aside, this level of indentation makes it almost impossible to review. Generally, lines should be kept under 80 columns. This particular function looks like it should be split into some helper functions, but it's hard to be constructive when it's so hard to read. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."