From: Christoph Hellwig <hch@lst.de>
To: Takashi Sato <t-sato@yk.jp.nec.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix FREEZE/THAW compat_ioctl regression
Date: Fri, 20 Feb 2009 10:51:58 +0100 [thread overview]
Message-ID: <20090220095158.GA9587@lst.de> (raw)
In-Reply-To: <20090216125725.GA3420@lst.de>
So who's going to send this to Linus? Having freeze/thaw regressed in
2.6.29 would be very sad for all the xfs users.
On Mon, Feb 16, 2009 at 01:57:25PM +0100, Christoph Hellwig wrote:
> Commit 8e961870bb9804110d5c8211d5d9d500451c4518 removed the FREEZE/THAW
> handling in xfs_compat_ioctl but never added any compat handler back, so
> now any freeze/thaw request from a 32-bit binary ond 64-bit userspace
> will fail.
>
> As these ioctls are 32/64-bit compatible two simple COMPATIBLE_IOCTL
> entries in fs/compat_ioctl.c will do the job.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfs/fs/compat_ioctl.c
> ===================================================================
> --- xfs.orig/fs/compat_ioctl.c 2009-02-16 12:48:23.000000000 +0000
> +++ xfs/fs/compat_ioctl.c 2009-02-16 12:49:34.000000000 +0000
> @@ -1913,6 +1913,9 @@
> /* 0x00 */
> COMPATIBLE_IOCTL(FIBMAP)
> COMPATIBLE_IOCTL(FIGETBSZ)
> +/* 'X' - originally XFS but some now in the VFS */
> +COMPATIBLE_IOCTL(FIFREEZE)
> +COMPATIBLE_IOCTL(FITHAW)
> /* RAID */
> COMPATIBLE_IOCTL(RAID_VERSION)
> COMPATIBLE_IOCTL(GET_ARRAY_INFO)
---end quoted text---
prev parent reply other threads:[~2009-02-20 9:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 12:57 [PATCH] fix FREEZE/THAW compat_ioctl regression Christoph Hellwig
2009-02-20 9:51 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090220095158.GA9587@lst.de \
--to=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=t-sato@yk.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).