* [PATCH] fix FREEZE/THAW compat_ioctl regression
@ 2009-02-16 12:57 Christoph Hellwig
2009-02-20 9:51 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2009-02-16 12:57 UTC (permalink / raw)
To: Takashi Sato; +Cc: linux-fsdevel, linux-kernel
Commit 8e961870bb9804110d5c8211d5d9d500451c4518 removed the FREEZE/THAW
handling in xfs_compat_ioctl but never added any compat handler back, so
now any freeze/thaw request from a 32-bit binary ond 64-bit userspace
will fail.
As these ioctls are 32/64-bit compatible two simple COMPATIBLE_IOCTL
entries in fs/compat_ioctl.c will do the job.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfs/fs/compat_ioctl.c
===================================================================
--- xfs.orig/fs/compat_ioctl.c 2009-02-16 12:48:23.000000000 +0000
+++ xfs/fs/compat_ioctl.c 2009-02-16 12:49:34.000000000 +0000
@@ -1913,6 +1913,9 @@
/* 0x00 */
COMPATIBLE_IOCTL(FIBMAP)
COMPATIBLE_IOCTL(FIGETBSZ)
+/* 'X' - originally XFS but some now in the VFS */
+COMPATIBLE_IOCTL(FIFREEZE)
+COMPATIBLE_IOCTL(FITHAW)
/* RAID */
COMPATIBLE_IOCTL(RAID_VERSION)
COMPATIBLE_IOCTL(GET_ARRAY_INFO)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fix FREEZE/THAW compat_ioctl regression
2009-02-16 12:57 [PATCH] fix FREEZE/THAW compat_ioctl regression Christoph Hellwig
@ 2009-02-20 9:51 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2009-02-20 9:51 UTC (permalink / raw)
To: Takashi Sato; +Cc: linux-fsdevel, linux-kernel
So who's going to send this to Linus? Having freeze/thaw regressed in
2.6.29 would be very sad for all the xfs users.
On Mon, Feb 16, 2009 at 01:57:25PM +0100, Christoph Hellwig wrote:
> Commit 8e961870bb9804110d5c8211d5d9d500451c4518 removed the FREEZE/THAW
> handling in xfs_compat_ioctl but never added any compat handler back, so
> now any freeze/thaw request from a 32-bit binary ond 64-bit userspace
> will fail.
>
> As these ioctls are 32/64-bit compatible two simple COMPATIBLE_IOCTL
> entries in fs/compat_ioctl.c will do the job.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfs/fs/compat_ioctl.c
> ===================================================================
> --- xfs.orig/fs/compat_ioctl.c 2009-02-16 12:48:23.000000000 +0000
> +++ xfs/fs/compat_ioctl.c 2009-02-16 12:49:34.000000000 +0000
> @@ -1913,6 +1913,9 @@
> /* 0x00 */
> COMPATIBLE_IOCTL(FIBMAP)
> COMPATIBLE_IOCTL(FIGETBSZ)
> +/* 'X' - originally XFS but some now in the VFS */
> +COMPATIBLE_IOCTL(FIFREEZE)
> +COMPATIBLE_IOCTL(FITHAW)
> /* RAID */
> COMPATIBLE_IOCTL(RAID_VERSION)
> COMPATIBLE_IOCTL(GET_ARRAY_INFO)
---end quoted text---
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-20 9:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-16 12:57 [PATCH] fix FREEZE/THAW compat_ioctl regression Christoph Hellwig
2009-02-20 9:51 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).