From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] fix FREEZE/THAW compat_ioctl regression Date: Fri, 20 Feb 2009 10:51:58 +0100 Message-ID: <20090220095158.GA9587@lst.de> References: <20090216125725.GA3420@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Takashi Sato Return-path: Received: from verein.lst.de ([213.95.11.210]:56674 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754126AbZBTJwB (ORCPT ); Fri, 20 Feb 2009 04:52:01 -0500 Content-Disposition: inline In-Reply-To: <20090216125725.GA3420@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: So who's going to send this to Linus? Having freeze/thaw regressed in 2.6.29 would be very sad for all the xfs users. On Mon, Feb 16, 2009 at 01:57:25PM +0100, Christoph Hellwig wrote: > Commit 8e961870bb9804110d5c8211d5d9d500451c4518 removed the FREEZE/THAW > handling in xfs_compat_ioctl but never added any compat handler back, so > now any freeze/thaw request from a 32-bit binary ond 64-bit userspace > will fail. > > As these ioctls are 32/64-bit compatible two simple COMPATIBLE_IOCTL > entries in fs/compat_ioctl.c will do the job. > > > Signed-off-by: Christoph Hellwig > > Index: xfs/fs/compat_ioctl.c > =================================================================== > --- xfs.orig/fs/compat_ioctl.c 2009-02-16 12:48:23.000000000 +0000 > +++ xfs/fs/compat_ioctl.c 2009-02-16 12:49:34.000000000 +0000 > @@ -1913,6 +1913,9 @@ > /* 0x00 */ > COMPATIBLE_IOCTL(FIBMAP) > COMPATIBLE_IOCTL(FIGETBSZ) > +/* 'X' - originally XFS but some now in the VFS */ > +COMPATIBLE_IOCTL(FIFREEZE) > +COMPATIBLE_IOCTL(FITHAW) > /* RAID */ > COMPATIBLE_IOCTL(RAID_VERSION) > COMPATIBLE_IOCTL(GET_ARRAY_INFO) ---end quoted text---