From: Andrew Morton <akpm@linux-foundation.org>
To: russell@rickstewart.com
Cc: bugme-daemon@bugzilla.kernel.org, linux-fsdevel@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>,
John McCutchan <john@johnmccutchan.com>,
Robert Love <rlove@rlove.org>
Subject: Re: [Bugme-new] [Bug 12754] New: inotify doesn't free memory allocated to watches
Date: Tue, 24 Feb 2009 13:05:23 -0800 [thread overview]
Message-ID: <20090224130523.f6c4c450.akpm@linux-foundation.org> (raw)
In-Reply-To: <bug-12754-10286@http.bugzilla.kernel.org/>
(switched to email. Please respond via emailed reply-to-all, not via the
bugzilla web interface).
On Sun, 22 Feb 2009 16:32:47 -0800 (PST)
bugme-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=12754
>
> Summary: inotify doesn't free memory allocated to watches
> Product: File System
> Version: 2.5
> KernelVersion: 2.6.28
> Platform: All
> OS/Version: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: Other
> AssignedTo: fs_other@kernel-bugs.osdl.org
> ReportedBy: russell@rickstewart.com
>
>
> Latest working kernel version: none
> Earliest failing kernel version:
> Distribution: CentOS 5
> Hardware Environment: intel
> Software Environment:
> Problem Description: run out of watches
>
> Steps to reproduce: use enough watches
>
> We have webcams that take photos every 5 minutes. I run a daemon
> that detects the creation of a new webcam photo then makes a thumbnail
> of it. Eventually it stopped working. I figured out that I could
> not create new watches: inotify_add_watch reported "No space left on device".
> I create all the watches with the ONESHOT parameter so they are deleted
> as soon as they are triggered. When I make it display the watch number
> it's always 3. A new watch is added only when the old watch has been
> triggered. inotify isn't recovering the memory from deleted watches.
>
So we have a serious leak.
A few fixes have gone into inotify since 2.6.28. I don't immediately
see any which would address this bug, but it would be worth testing
2.6.29-rc6 if poss, please. Hopefully those fixes also got fed back
into 2.6.28.x, but that path is somewhat unreliable.
If it isn't yet fixed then I'm not sure how to get it fixed, really -
inotify development is a bit quiet.
next parent reply other threads:[~2009-02-24 21:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-12754-10286@http.bugzilla.kernel.org/>
2009-02-24 21:05 ` Andrew Morton [this message]
2009-02-24 21:38 ` [Bugme-new] [Bug 12754] New: inotify doesn't free memory allocated to watches Al Viro
2009-02-24 23:23 ` Al Viro
2009-02-24 23:40 ` Andrew Morton
2009-02-25 0:28 ` Al Viro
2009-02-25 0:40 ` Andrew Morton
2009-02-25 2:38 ` Josef Bacik
2009-02-25 3:13 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090224130523.f6c4c450.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=john@johnmccutchan.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rlove@rlove.org \
--cc=russell@rickstewart.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).