From: Nick Piggin <npiggin@suse.de>
To: Zach Brown <zach.brown@oracle.com>
Cc: linux-fsdevel@vger.kernel.org,
Linux Memory Management List <linux-mm@kvack.org>,
Mark Fasheh <mfasheh@suse.com>, Sage Weil <sage@newdream.net>
Subject: Re: [patch][rfc] mm: hold page lock over page_mkwrite
Date: Wed, 25 Feb 2009 18:02:40 +0100 [thread overview]
Message-ID: <20090225170240.GL22785@wotan.suse.de> (raw)
In-Reply-To: <49A5789E.4040600@oracle.com>
(Chris, your point about lock ordering is good. Zach raised the
same one. Thanks for the good catch there guys).
On Wed, Feb 25, 2009 at 08:58:06AM -0800, Zach Brown wrote:
>
> > Is ocfs2 immune to the races that get covered by this patch?
>
> I haven't the slightest idea.
Well, they would be covered with the new scheme anyway:
> > Hmm, actually possibly we can enter page_mkwrite with the page unlocked,
> > but exit with the page locked? Slightly more complex, but should save
> > complexity elsewhere. Yes I think this might be the best way to go.
>
> That sounds like it would work on first glance, yeah. Mark will yell at
> us if we've gotten it wrong ;).
OK, thanks. I'll go with that approach and see what happens.
next prev parent reply other threads:[~2009-02-25 17:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 9:36 [patch][rfc] mm: hold page lock over page_mkwrite Nick Piggin
2009-02-25 16:42 ` Zach Brown
2009-02-25 16:55 ` Nick Piggin
2009-02-25 16:58 ` Zach Brown
2009-02-25 17:02 ` Nick Piggin [this message]
2009-02-25 22:35 ` Mark Fasheh
2009-02-25 16:48 ` Chris Mason
2009-02-26 9:20 ` Peter Zijlstra
2009-02-26 11:09 ` Nick Piggin
2009-03-01 8:17 ` Dave Chinner
2009-03-01 13:50 ` Nick Piggin
2009-03-02 8:19 ` Dave Chinner
2009-03-02 8:37 ` Nick Piggin
2009-03-02 15:26 ` jim owens
2009-03-03 4:33 ` Nick Piggin
2009-03-03 17:25 ` Jamie Lokier
2009-03-04 4:37 ` Dave Chinner
2009-03-04 9:23 ` Nick Piggin
2009-03-04 18:13 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090225170240.GL22785@wotan.suse.de \
--to=npiggin@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mfasheh@suse.com \
--cc=sage@newdream.net \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).