* [hch: [PATCH] fix FREEZE/THAW compat_ioctl regression]
@ 2009-02-26 20:32 Christoph Hellwig
0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2009-02-26 20:32 UTC (permalink / raw)
To: torvalds; +Cc: Takashi Sato, linux-fsdevel, linux-kernel
[I sent this 10 days ago to lkml and fsdevel and didn't get a single
reply yet, can we please get this in so we don't have that regression
in 2.6.29?]
Commit 8e961870bb9804110d5c8211d5d9d500451c4518 removed the FREEZE/THAW
handling in xfs_compat_ioctl but never added any compat handler back, so
now any freeze/thaw request from a 32-bit binary ond 64-bit userspace
will fail.
As these ioctls are 32/64-bit compatible two simple COMPATIBLE_IOCTL
entries in fs/compat_ioctl.c will do the job.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfs/fs/compat_ioctl.c
===================================================================
--- xfs.orig/fs/compat_ioctl.c 2009-02-16 12:48:23.000000000 +0000
+++ xfs/fs/compat_ioctl.c 2009-02-16 12:49:34.000000000 +0000
@@ -1913,6 +1913,9 @@
/* 0x00 */
COMPATIBLE_IOCTL(FIBMAP)
COMPATIBLE_IOCTL(FIGETBSZ)
+/* 'X' - originally XFS but some now in the VFS */
+COMPATIBLE_IOCTL(FIFREEZE)
+COMPATIBLE_IOCTL(FITHAW)
/* RAID */
COMPATIBLE_IOCTL(RAID_VERSION)
COMPATIBLE_IOCTL(GET_ARRAY_INFO)
----- End forwarded message -----
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-02-26 20:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-26 20:32 [hch: [PATCH] fix FREEZE/THAW compat_ioctl regression] Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).