From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [patch 1/2] mm: page_mkwrite change prototype to match fault
Date: Tue, 3 Mar 2009 10:58:35 -0500
Message-ID: <20090303155835.GA28851@infradead.org>
References: <20090303103838.GC17042@wotan.suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Linux Memory Management List <linux-mm@kvack.org>,
	linux-fsdevel@vger.kernel.org
To: Nick Piggin <npiggin@suse.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:38347 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753428AbZCCP6i (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 3 Mar 2009 10:58:38 -0500
Content-Disposition: inline
In-Reply-To: <20090303103838.GC17042@wotan.suse.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Mar 03, 2009 at 11:38:38AM +0100, Nick Piggin wrote:
> 
> Change the page_mkwrite prototype to take a struct vm_fault, and return
> VM_FAULT_xxx flags. Same as ->fault handler. Should be no change in
> behaviour.

How about just merging it into ->fault?

> This is required for a subsequent fix. And will also make it easier to
> merge page_mkwrite() with fault() in future.

Ah, I should read until the end :)  Any reason not to do the merge just
yet?