From: Nick Piggin <npiggin@suse.de>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Jorge Boncompte [DTI2]" <jorge@dti2.net>,
Adrian Hunter <ext-adrian.hunter@nokia.com>,
stable@kernel.org
Subject: Re: [patch] fs: new inode i_state corruption fix
Date: Thu, 5 Mar 2009 11:16:37 +0100 [thread overview]
Message-ID: <20090305101637.GB17815@wotan.suse.de> (raw)
In-Reply-To: <20090305100000.GA29177@duck.suse.cz>
On Thu, Mar 05, 2009 at 11:00:01AM +0100, Jan Kara wrote:
> On Thu 05-03-09 07:45:54, Nick Piggin wrote:
> > after ~1hour of running. Previously, the new warnings would start immediately
> > and hang would happen in under 5 minutes.
> A quick grep seems to indicate that you've still missed a few cases,
> haven't you? I still see the same problem in
> drop_caches.c:drop_pagecache_sb() scanning, inode.c:invalidate_inodes()
> scanning, and dquot.c:add_dquot_ref() scanning.
> Otherwise the patch looks fine.
I thought they should be OK; drop_pagecache_sb doesn't play with flags,
invalidate_inodes won't if refcount is elevated, and I think add_dquot_ref
won't if writecount is not elevated...
But maybe that's abit fragile and it would be better policy to always
skip I_NEW in these traverals?
next prev parent reply other threads:[~2009-03-05 10:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 6:45 [patch] fs: new inode i_state corruption fix Nick Piggin
2009-03-05 10:00 ` Jan Kara
2009-03-05 10:16 ` Nick Piggin [this message]
2009-03-05 11:12 ` Jan Kara
2009-03-10 13:41 ` [patch] fs: avoid I_NEW inodes Nick Piggin
2009-03-10 16:03 ` Jan Kara
2009-03-11 2:34 ` Nick Piggin
2009-03-11 12:22 ` Jan Kara
2009-03-11 3:29 ` Nick Piggin
2009-03-11 12:24 ` Jan Kara
2009-03-11 12:57 ` Nick Piggin
2009-03-11 20:19 ` Andrew Morton
2009-03-12 3:09 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090305101637.GB17815@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=ext-adrian.hunter@nokia.com \
--cc=jack@suse.cz \
--cc=jorge@dti2.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).