From: Nick Piggin <npiggin@suse.de>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Dave Hansen <haveblue@us.ibm.com>
Subject: Re: [patch 2/2] fs: introduce mnt_clone_write
Date: Tue, 10 Mar 2009 16:08:41 +0100 [thread overview]
Message-ID: <20090310150841.GB8579@wotan.suse.de> (raw)
In-Reply-To: <20090310145558.GY25995@parisc-linux.org>
On Tue, Mar 10, 2009 at 08:55:58AM -0600, Matthew Wilcox wrote:
> On Tue, Mar 10, 2009 at 03:38:01PM +0100, Nick Piggin wrote:
> > +EXPORT_SYMBOL_GPL(mnt_clone_write);
> > +EXPORT_SYMBOL_GPL(mnt_want_write_file);
>
> You don't add any users of these functions in this patch ... is there a
> good reason to export them?
Only to encourage modular code to use them (as a replacement for
mnt_want_write -- which itself is exported).
If that's not the right way to go, I don't mind waiting for a
user to turn up.
[I see many ioctls in btrfs (coming first in the alphabet) could
probably easily use mnt_want_write_file (otoh probably none are
so performance critical).]
next prev parent reply other threads:[~2009-03-10 15:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 14:37 [patch 1/2] fs: mnt_want_write speedup Nick Piggin
2009-03-10 14:38 ` [patch 2/2] fs: introduce mnt_clone_write Nick Piggin
2009-03-10 14:55 ` Matthew Wilcox
2009-03-10 15:08 ` Nick Piggin [this message]
2009-03-10 14:48 ` [patch 1/2] fs: mnt_want_write speedup Matthew Wilcox
2009-03-10 15:03 ` Nick Piggin
2009-03-10 15:31 ` Nick Piggin
2009-03-11 22:11 ` Dave Hansen
2009-03-12 4:13 ` Nick Piggin
2009-03-18 19:13 ` Dave Hansen
2009-04-02 18:22 ` Nick Piggin
2009-04-02 18:37 ` Dave Hansen
2009-04-02 20:31 ` Christoph Hellwig
2009-04-03 1:29 ` Nick Piggin
2009-04-02 18:43 ` Al Viro
2009-04-02 18:48 ` Al Viro
2009-04-02 19:08 ` Dave Hansen
2009-04-03 10:31 ` Al Viro
2009-04-03 1:31 ` Nick Piggin
2009-04-02 18:08 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090310150841.GB8579@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=haveblue@us.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).