From: Nick Piggin <npiggin@suse.de>
To: linux-fsdevel@vger.kernel.org
Subject: inotify_unmount_inodes badness?
Date: Wed, 11 Mar 2009 04:46:07 +0100 [thread overview]
Message-ID: <20090311034607.GG16561@wotan.suse.de> (raw)
inotify_unmount_inodes does this hairly looking thing with
list_for_each_entry_safe, where it tries to take a reference
to the "next" inode as well as the current, before dropping
inode_lock. But it doesn't take a reference on inodes without
a refcount, or I_CLEAR|I_FREEING|I_WILL_FREE inodes before
dropping the lock. Can't these guys just go away at any time?
Why does it need the safe list traveral anyway (which is causing
this complexity)? We don't remove the inode from its sb list
here, do we??
reply other threads:[~2009-03-11 3:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090311034607.GG16561@wotan.suse.de \
--to=npiggin@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).